Unreal Engine 4 Plugin #647

YannickLange · 2019-03-13T16:30:01Z

Initial Unreal Engine 4 Plugin for Agones.

The problem with having the plugin within this repository is that people will have to copy the directory in to the Plugins folder of each Unreal Engine project that uses Agones. They would also have to do this when there is a new version of the plugin. In addition to that it might be less clean regarding branching and binaries for different Unreal Engine versions. I made a seperate repository for just the plugin (https://github.com/YannickLange/UEAgones). So people can just clone that. It might be an idea to do "active" development there and then pull the changes to the agones repo?

Anyway. Try it out, would love to hear feedback!

googlebot · 2019-03-13T16:30:04Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

markmandel

🔥 Awwwwweeeeeesome 🔥

Some thoughts:

Should the folder be "Unreal" rather than "UEAgones" ?
We'll definitely want some docs for this.

I also need to find someone who knows Unreal to review 😄

agones-bot · 2019-03-13T16:40:32Z

Build Succeeded 👏

Build Id: 907b9c80-4fe2-4640-bbe6-c73c80f4b1a0

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.9.0-e0da9e3
image: gcr.io/agones-images/agones-sdk:0.9.0-e0da9e3
image: gcr.io/agones-images/agones-ping:0.9.0-e0da9e3
Linux C++ SDK (build: dev): agonessdk-0.9.0-e0da9e3-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.9.0-e0da9e3-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.9.0-e0da9e3-src.zip
SDK Server: agonessdk-server-0.9.0-e0da9e3.zip

A preview of the website (the last 30 builds are retained):

https://e0da9e3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/647/head:pr_647 && git checkout pr_647
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-e0da9e3

YannickLange · 2019-03-13T17:05:10Z

🔥 Awwwwweeeeeesome 🔥

Some thoughts:

Should the folder be "Unreal" rather than "UEAgones" ?

We'll definitely want some docs for this.

I also need to find someone who knows Unreal to review 😄

I might be better to name the directory Unreal and within that directory Agones, because that directory needs to be copied into the Plugins directory within the Unreal Engine project. Would be weird to have a Plugins > Unreal directory while it is the Agones plugin.
I will write those later and give them to you so you can add and test it for the website.

fdasoghe · 2019-03-13T17:16:25Z

I'm very interested in trying out this plugin, but I'm not much used to install new plugins into Unreal. Is there some docs I can read/follow to know how to do it right?

YannickLange · 2019-03-13T17:43:05Z

I'm very interested in trying out this plugin, but I'm not much used to install new plugins into Unreal. Is there some docs I can read/follow to know how to do it right?

I'll write docs later, but it comes down to the general steps. I assume you already have done/been able to do 1, 3, 4 and 6. Only 2 and 4 are related to the plugin. No coding required 😃

Have project with Unreal Engine from source code
Add this directory to your Plugins directory within your Unreal Engine Project
Setup cross compilation so you can compile Unreal Engine + your game (including the plugin) for Linux
Compile your game for Linux with Development Server
Make sure the plugin is enabled within your game (restart the editor if it wasn't)
Package your game

Hope that helps for now!

dsazonoff · 2019-03-13T23:16:11Z

Code looks ok. I don't think that we need to follow google codestyle for that, because UE has its own. Maybe I can build and test a bit later.
A small remark about copyrights in source code: they all should be 2019 - the date when file was added to repo.

steven-supersolid · 2019-03-14T10:01:05Z

I've been wondering how we might approach a Unity SDK so now following this PR with some interest. Has any thought been given to using gRPC instead of using the REST API?
Also, as I don't know Unreal, would it be possible to wrap the current C++ Agones SDK, and would there be value in doing this as that does use generated code?

fdasoghe · 2019-03-14T10:05:12Z

Has any thought been given to using gRPC instead of using the REST API?

I've tried it (on Linux) and others here have done it on Windows. Integration of gRpc in Unreal Engine is quite an hell at the moment, basically for incompatibility between gRpc compiler settings/base libraries and Unreal's.

dsazonoff · 2019-03-14T12:10:53Z

I've tried it (on Linux) and others here have done it on Windows. Integration of gRpc in Unreal Engine is quite an hell at the moment, basically for incompatibility between gRpc compiler settings/base libraries and Unreal's.

What do you think about using agones-cpp-sdk as a shared library as a base for UE plugin instead of direct implementation of SDK? Shared library will include all necessary gRPC stuff, so there should be no compiler/linker issues.

fdasoghe · 2019-03-14T14:27:57Z

What do you think about using agones-cpp-sdk as a shared library as a base for UE plugin instead of direct implementation of SDK? Shared library will include all necessary gRPC stuff, so there should be no compiler/linker issues.

As I said, I'm far from being an expert, all I know is that I've wasted several weeks trying to build UE4 with gRpc and I ended giving up and resorting to the REST interface.

Having said that, using the shared library should solve compiler/linker issues, but my fear is that you could end up finding those same issues between agones-cpp-sdk and Unreal. Unfortunately the Unreal build process is very cumbersome and poor documented: it's very picky on compiler version and flags, I digged through a lot of different problems and errors one after another so I cannot really feel confident on what to say about your question.

I would say Agones is becoming quickly such an important and notable project that someone at Epic could decide to put some effort in helping this integration (at least documenting what's needed).

EDIT: I've found an older thread about this: #138 that ended with this work: https://github.com/iniside/ue-grpc

YannickLange · 2019-03-14T18:09:05Z

What do you think about using agones-cpp-sdk as a shared library as a base for UE plugin instead of direct implementation of SDK? Shared library will include all necessary gRPC stuff, so there should be no compiler/linker issues.

As I said, I'm far from being an expert, all I know is that I've wasted several weeks trying to build UE4 with gRpc and I ended giving up and resorting to the REST interface.

Having said that, using the shared library should solve compiler/linker issues, but my fear is that you could end up finding those same issues between agones-cpp-sdk and Unreal. Unfortunately the Unreal build process is very cumbersome and poor documented: it's very picky on compiler version and flags, I digged through a lot of different problems and errors one after another so I cannot really feel confident on what to say about your question.

I would say Agones is becoming quickly such an important and notable project that someone at Epic could decide to put some effort in helping this integration (at least documenting what's needed).

EDIT: I've found an older thread about this: #138 that ended with this work: https://github.com/iniside/ue-grpc

I worked at Epic and I don't see them integrating Agones at all. They might add a grpc plugin, which would be nice. In addition to that, a plugin is way better for the Agones community, so the community has more control over it.

YannickLange · 2019-03-14T18:10:45Z

Code looks ok. I don't think that we need to follow google codestyle for that, because UE has its own. Maybe I can build and test a bit later.
A small remark about copyrights in source code: they all should be 2019 - the date when file was added to repo.

The codestyle should be Epics/Unreal's C++ code style. That's also what a large percentage of Unreal Engine users are using.
You are right, will modify it

Zanderax · 2019-03-14T21:34:04Z

Awesome work Yannick! Is there a reason that GameServer, WatchGameServer, SetAnnotation and SetLabel aren't implemented?

YannickLange · 2019-03-15T09:12:27Z

Awesome work Yannick! Is there a reason that GameServer, WatchGameServer, SetAnnotation and SetLabel aren't implemented?

Just haven't had time for that.

markmandel · 2019-03-26T00:06:33Z

Just a gentle bump - our release candidate is hitting tomorrow, at which point we hit feature freeze for a week. Be great to get the outstanding items in this PR done so we can have this in this upcoming release.

dsazonoff · 2019-03-26T12:12:30Z

@YannickLange I suggest to use existing cpp sdk instead of making manual http requests. Now it is possible to build cpp sdk as a dynamic library for all platforms (with CMake and AGONES_BUILD_SHARED=ON), so there will be no direct gRPC dependency (so it is not necessary to build gRPC with UE build system). If you have any questions related to building cpp sdk, feel free to contact me.

- Changed copyright to 2019 - Removed unused REAMDE.md

agones-bot · 2019-04-08T11:05:48Z

Build Failed 😱

Build Id: cf9d42b1-956e-40e0-89f4-f36c621abcc3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

site/content/en/docs/Guides/Client SDKs/unreal.md

Co-Authored-By: YannickLange <YannickLange@users.noreply.github.com>

agones-bot · 2019-04-15T20:50:46Z

Build Failed 😱

Build Id: a6acdceb-d0a7-4e1f-bd65-b3151c9ec14b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-04-15T21:40:38Z

Build Succeeded 👏

Build Id: dc6f059b-0b6b-421f-b4b1-390fd993a45e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.10.0-0dd3cba
image: gcr.io/agones-images/agones-sdk:0.10.0-0dd3cba
image: gcr.io/agones-images/agones-ping:0.10.0-0dd3cba
Linux C++ SDK (build): agonessdk-0.10.0-0dd3cba-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.10.0-0dd3cba.zip

A preview of the website (the last 30 builds are retained):

https://0dd3cba-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/647/head:pr_647 && git checkout pr_647
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-0dd3cba

markmandel · 2019-04-16T02:42:30Z

Wh00t! We have a working build!

So - final, final things.

Per contributor guidelines please squash the commits down to a single commit
Please sign the CLA. We can't accept the PR until you do so 😞

Really looking forward to having this in the repository finally though!!!

YannickLange · 2019-04-18T09:49:33Z

Wh00t! We have a working build!

So - final, final things.

Per contributor guidelines please squash the commits down to a single commit

Please sign the CLA. We can't accept the PR until you do so 😞

Really looking forward to having this in the repository finally though!!!

Signed it! Let's go !!!!

googlebot · 2019-04-18T09:49:39Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

markmandel · 2019-04-18T13:38:46Z

Per contributor guidelines please squash the commits down to a single commit

^ sorry, still got one more step. Almost there!

markmandel · 2019-04-25T17:19:46Z

Gentle bump 😄 just need this squashed, and its good to go.

agones-bot · 2019-04-27T18:33:40Z

Build Succeeded 👏

Build Id: 6e81bf37-0ca4-47d2-b5b9-f75be7082172

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.10.0-fd9691f
image: gcr.io/agones-images/agones-sdk:0.10.0-fd9691f
image: gcr.io/agones-images/agones-ping:0.10.0-fd9691f
Linux C++ SDK (build): agonessdk-0.10.0-fd9691f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.10.0-fd9691f.zip

A preview of the website (the last 30 builds are retained):

https://fd9691f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/647/head:pr_647 && git checkout pr_647
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-fd9691f

markmandel

🤩

Unreal Engine 4 Plugin

e0da9e3

markmandel reviewed Mar 13, 2019

View reviewed changes

YannickLange mentioned this pull request Mar 13, 2019

Integration with Unreal Engine #138

Closed

markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels Mar 26, 2019

Added docs and moved plugin to unreal folder.

5ec463e

- Changed copyright to 2019 - Removed unused REAMDE.md

markmandel removed feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels Apr 12, 2019

markmandel reviewed Apr 13, 2019

View reviewed changes

site/content/en/docs/Guides/Client SDKs/unreal.md Outdated Show resolved Hide resolved

Update unreal.md date

b187737

Co-Authored-By: YannickLange <YannickLange@users.noreply.github.com>

Merge branch 'master' into master

0dd3cba

Merge branch 'master' into master

fd9691f

markmandel approved these changes Apr 27, 2019

View reviewed changes

markmandel merged commit edd582f into googleforgames:master Apr 27, 2019

markmandel added this to the 0.10.0 milestone May 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unreal Engine 4 Plugin #647

Unreal Engine 4 Plugin #647

YannickLange commented Mar 13, 2019 •

edited

Loading

googlebot commented Mar 13, 2019

markmandel left a comment

agones-bot commented Mar 13, 2019

YannickLange commented Mar 13, 2019

fdasoghe commented Mar 13, 2019

YannickLange commented Mar 13, 2019

dsazonoff commented Mar 13, 2019

steven-supersolid commented Mar 14, 2019

fdasoghe commented Mar 14, 2019

dsazonoff commented Mar 14, 2019 •

edited

Loading

fdasoghe commented Mar 14, 2019 •

edited

Loading

YannickLange commented Mar 14, 2019 •

edited

Loading

YannickLange commented Mar 14, 2019

Zanderax commented Mar 14, 2019

YannickLange commented Mar 15, 2019

markmandel commented Mar 26, 2019

dsazonoff commented Mar 26, 2019

agones-bot commented Apr 8, 2019

agones-bot commented Apr 15, 2019

agones-bot commented Apr 15, 2019

markmandel commented Apr 16, 2019

YannickLange commented Apr 18, 2019

googlebot commented Apr 18, 2019

markmandel commented Apr 18, 2019

markmandel commented Apr 25, 2019

agones-bot commented Apr 27, 2019

markmandel left a comment

Unreal Engine 4 Plugin #647

Unreal Engine 4 Plugin #647

Conversation

YannickLange commented Mar 13, 2019 • edited Loading

googlebot commented Mar 13, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Mar 13, 2019

YannickLange commented Mar 13, 2019

fdasoghe commented Mar 13, 2019

YannickLange commented Mar 13, 2019

dsazonoff commented Mar 13, 2019

steven-supersolid commented Mar 14, 2019

fdasoghe commented Mar 14, 2019

dsazonoff commented Mar 14, 2019 • edited Loading

fdasoghe commented Mar 14, 2019 • edited Loading

YannickLange commented Mar 14, 2019 • edited Loading

YannickLange commented Mar 14, 2019

Zanderax commented Mar 14, 2019

YannickLange commented Mar 15, 2019

markmandel commented Mar 26, 2019

dsazonoff commented Mar 26, 2019

agones-bot commented Apr 8, 2019

agones-bot commented Apr 15, 2019

agones-bot commented Apr 15, 2019

markmandel commented Apr 16, 2019

YannickLange commented Apr 18, 2019

googlebot commented Apr 18, 2019

markmandel commented Apr 18, 2019

markmandel commented Apr 25, 2019

agones-bot commented Apr 27, 2019

markmandel left a comment

Choose a reason for hiding this comment

YannickLange commented Mar 13, 2019 •

edited

Loading

dsazonoff commented Mar 14, 2019 •

edited

Loading

fdasoghe commented Mar 14, 2019 •

edited

Loading

YannickLange commented Mar 14, 2019 •

edited

Loading