Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url pointing to install.yaml pointing to master #676

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Url pointing to install.yaml pointing to master #676

merged 1 commit into from
Mar 28, 2019

Conversation

markmandel
Copy link
Member

url was pointing to 0.7.0 install.yaml which was not the latest.

Original PR: #648

Co-Authored-By: mathieuduperre mathieu.duperre@gmail.com

@mathieuduperre @markmandel
Url pointing to install.yaml pointing to master
7360123 
url was pointing to 0.7.0 install.yaml which was not the latest.

Original PR: googleforgames#648

Co-Authored-By: mathieuduperre <mathieu.duperre@gmail.com>
@markmandel markmandel added kind/bug These are bugs. kind/documentation Documentation for Agones labels Mar 28, 2019
@markmandel markmandel added this to the 0.9.0 milestone Mar 28, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@markmandel
Copy link
Member Author

@mathieuduperre can you drop a note in here stating you consent to me merging this PR please?

(Also I found another spot, and merged this into this PR)

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ac588407-4ef1-4d55-bbb4-97686efbf3b4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/676/head:pr_676 && git checkout pr_676
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-7360123

@mathieuduperre
Copy link
Contributor

this is ok to merge

@markmandel markmandel merged commit c45c988 into googleforgames:master Mar 28, 2019
@markmandel markmandel deleted the pull/648 branch March 28, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/bug These are bugs. kind/documentation Documentation for Agones
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @googlebot @agones-bot @mathieuduperre