-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Supersolid logo to the homepage #727
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
site/static/css/asciinema-player.css
Outdated
@@ -2561,3 +2561,6 @@ | |||
.asciinema-theme-monokai .fg-15 { | |||
font-weight: bold; | |||
} | |||
.showcase img { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use this file instead https://github.com/GoogleCloudPlatform/agones/blob/master/site/assets/scss/_variables_project.scss , thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KamiShepard just making sure you saw this 👍 looking forward to getting this in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry was on holiday, just pushed a fix!
Build Succeeded 👏 Build Id: 72107c3e-a516-476c-ae62-3dd209fa6025 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Looks good visually! |
Build Succeeded 👏 Build Id: d5ab609e-3b6a-4f6a-b56b-3b34b82a4ccc The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Thanks so much 😄 Looks perfect! One small thing - can we rebase into a single commit please, and then force push over the top, and this will then be good to go! 👍 |
Build Succeeded 👏 Build Id: 7b44555f-3904-494f-b92c-dd68af889db0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Gentle reminder: Just need you to squash this to a single commit please, and then this is good to go 👍 |
There's a new squash and rebase on GitHub
Le ven. 26 avr. 2019 à 12:20, Mark Mandel <notifications@github.com> a
écrit :
Gentle reminder: Just need you to squash this to a single commit please,
and then this is good to go 👍
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#727 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIBF3MXMKHKVIEGWQ24MZDPSMTU7ANCNFSM4HG6LEGQ>
.
--
Cyril Tovena
|
That would be lovely - but I can't find it anywhere 😢 You got a URL? |
Build Succeeded 👏 Build Id: d0e41ed5-4714-4232-917d-03275469df2c The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Okay - let's do an experiment, and see how squash+merge looks! |
Added logo, some styling to make it more spread and fixed what looked like a typo