Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intial tool vendoring commit. #737

Merged
merged 2 commits into from
Apr 25, 2019
Merged

Intial tool vendoring commit. #737

merged 2 commits into from
Apr 25, 2019

Conversation

heartrobotninja
Copy link
Contributor

Gets most tools into tools.go, but only sets vendoring for gen script in go
sdk build directory.

Part 1 for #695

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a8e902bf-5d38-4489-bf40-b146f8c64081

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c7672a60-add6-40a7-b479-46e75af9fab0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c412b8ce-66f3-4054-a12f-fdcd50a5f760

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1b1cc44e-5478-4226-961a-f39e73b709ad

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/737/head:pr_737 && git checkout pr_737
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-31e72f4

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 60cb968e-58bb-4f97-9018-88a2be37977e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/737/head:pr_737 && git checkout pr_737
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-0f00690

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 42c73378-ade8-453c-a5b2-e6eace334b62

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/737/head:pr_737 && git checkout pr_737
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-d53c473

markmandel
markmandel reviewed Apr 23, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good - just had a few questions 👍

tools.go Show resolved Hide resolved
go.mod Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: bf284e33-bd8e-46cb-831d-4ffb9fbfd3ba

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/737/head:pr_737 && git checkout pr_737
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-cff1b0a

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@heartrobotninja
Intial tool vendoring commit.
ce7c57a 
Gets most tools into tools.go, but only sets vendoring for gen script in go
sdk build directory.

Change package tools to package agones.

Fix code-generator module vendoring.

Add code-generator vendored files for real.

Remove code-generator from tool vendoring.

code-generator has a problem with vendoring correctly when the correct
version is put in a replace directive. Until such time that we figure
out how to get the correct behavior, we cannot use the module vendored
version of code-generator.
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 61ab17be-3bc1-4c14-8c3f-aea6a0c340ab

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/737/head:pr_737 && git checkout pr_737
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-f3d6cb5

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 532ada21-cfd9-4fe6-8699-139500d8af37

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/737/head:pr_737 && git checkout pr_737
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-ce7c57a

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5e80d853-1ecf-4adf-b4b2-a35b18d4b5a6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/737/head:pr_737 && git checkout pr_737
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-9fb09b2

markmandel
markmandel approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shaved 2 minutes off our build times! Nice!

@markmandel markmandel merged commit bd6d072 into googleforgames:master Apr 25, 2019
@markmandel markmandel added the area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. label Apr 27, 2019
@markmandel markmandel added this to the 0.10.0 milestone Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory.
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@heartrobotninja @agones-bot @googlebot @markmandel