Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We don't need CMake in the base build image #739

Merged
merged 2 commits into from
May 1, 2019
Merged

We don't need CMake in the base build image #739

merged 2 commits into from
May 1, 2019

Conversation

markmandel
Copy link
Member

No description provided.

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Apr 24, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 690450c9-157f-48a8-ad82-c8873a6989a5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/739/head:pr_739 && git checkout pr_739
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-343b487

@markmandel
Copy link
Member Author

@dsazonoff see any issue with removing this?

@markmandel markmandel marked this pull request as ready for review April 24, 2019 01:10
@markmandel markmandel added the area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. label Apr 24, 2019
@dsazonoff
Copy link
Contributor

@dsazonoff see any issue with removing this?

Everything looks good.

cyriltovena
cyriltovena approved these changes May 1, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 54aab613-7d5c-4270-82d6-6001dedc9445

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6d6bcb79-507b-4841-b25f-0e40d0d439ea

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/739/head:pr_739 && git checkout pr_739
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-e69e804

@markmandel markmandel merged commit 960d821 into googleforgames:master May 1, 2019
@markmandel markmandel deleted the cleanup/no-cmake-build-image branch May 1, 2019 18:50
@markmandel markmandel added this to the 0.10.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @dsazonoff @cyriltovena