Updated the filtering condition on GameServerShutdown to include the undeleted Unhealthy GSs

[ilkercelikyilmaz]

Fixed the filtering condition on GameServerShutdown to include the undeleted Unhealthy GSs.
After the change the Unhealthy servers are (eventually) being deleted(see the graph below).

Also remove the WaitForCacheSync call during the GS creation. This improves the allocation and overall performance.

[agones-bot]

Build Failed 😱

Build Id: 0bbec6bf-fd94-4b26-a64b-11df9ae5b4a4

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

[agones-bot]

Build Succeeded 👏

Build Id: c66af9bd-c543-4fa5-bbd2-f3b441c61b62

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.10.0-947799e
• image: gcr.io/agones-images/agones-sdk:0.10.0-947799e
• image: gcr.io/agones-images/agones-ping:0.10.0-947799e
• Linux C++ SDK (build): agonessdk-0.10.0-947799e-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.10.0-947799e.zip

A preview of the website (the last 30 builds are retained):

• https://947799e-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/740/head:pr_740 && git checkout pr_740
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-947799e

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[agones-bot]

Build Succeeded 👏

Build Id: 9349ae97-0c4c-4205-8ed6-a36c18aa68a9

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.10.0-0804600
• image: gcr.io/agones-images/agones-sdk:0.10.0-0804600
• image: gcr.io/agones-images/agones-ping:0.10.0-0804600
• Linux C++ SDK (build): agonessdk-0.10.0-0804600-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.10.0-0804600.zip

A preview of the website (the last 30 builds are retained):

• https://0804600-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/740/head:pr_740 && git checkout pr_740
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-0804600

[markmandel]

Nice! 🎁

[markmandel]

Oops, sorry - can we squish this to one commit plz?

[ilkercelikyilmaz]

Oops, sorry - can we squish this to one commit plz?

Done

[agones-bot]

Build Succeeded 👏

Build Id: 65c32438-c1c8-49e7-816a-9bf822ab5047

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.10.0-72ca155
• image: gcr.io/agones-images/agones-sdk:0.10.0-72ca155
• image: gcr.io/agones-images/agones-ping:0.10.0-72ca155
• Linux C++ SDK (build): agonessdk-0.10.0-72ca155-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.10.0-72ca155.zip

A preview of the website (the last 30 builds are retained):

• https://72ca155-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/740/head:pr_740 && git checkout pr_740
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-72ca155

[markmandel]

Thank you! 💪