Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert C++ Example to Docker Build Pattern #746

Merged

Conversation

markmandel
Copy link
Member

@markmandel markmandel commented Apr 25, 2019

While this does make it a longer build time, it makes it easier to get started with the C++ example because there is no tooling dependencies other than Docker (Make is even optional, it just sets the default arguments up).

Also provides an end to end example of compiling the SDK, installing it and then using it with another C++ project.

Co-authored-by: @dsazonoff

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/examples Examples. Usually found in the `examples` directory labels Apr 25, 2019
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

While this does make it a longer build time, it makes it easier to get
started with the C++ example because there is no tooling dependencies
other than Docker (Make is even optional, it just sets the default
arguments up).

Also provides an end to end example of compiling the SDK, installing it
and then using it with another C++ project.

Co-authored-by: Dmitry Sazonov <dmitry.sazonov@globant.com>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@markmandel
Copy link
Member Author

/cc @dsazonoff Please confirm you are good with these changes being applied 😄

Also do you see any issues here?

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ee4c5c51-b687-443a-9541-8783106643dd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/746/head:pr_746 && git checkout pr_746
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-eab4045

@dsazonoff
Copy link
Contributor

Looks good.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e8216bf0-ef54-4cc9-86a2-3999cf71845e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/746/head:pr_746 && git checkout pr_746
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-c0dc2b0

@markmandel markmandel merged commit f0c6e96 into googleforgames:master May 7, 2019
@markmandel markmandel deleted the exmaples/cpp-build-docker branch May 7, 2019 19:08
@markmandel markmandel added this to the 0.10.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants