-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert C++ Example to Docker Build Pattern #746
Convert C++ Example to Docker Build Pattern #746
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
While this does make it a longer build time, it makes it easier to get started with the C++ example because there is no tooling dependencies other than Docker (Make is even optional, it just sets the default arguments up). Also provides an end to end example of compiling the SDK, installing it and then using it with another C++ project. Co-authored-by: Dmitry Sazonov <dmitry.sazonov@globant.com>
e98e2b8
to
eab4045
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
/cc @dsazonoff Please confirm you are good with these changes being applied 😄 Also do you see any issues here? |
Build Succeeded 👏 Build Id: ee4c5c51-b687-443a-9541-8783106643dd The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Looks good. |
Build Succeeded 👏 Build Id: e8216bf0-ef54-4cc9-86a2-3999cf71845e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
While this does make it a longer build time, it makes it easier to get started with the C++ example because there is no tooling dependencies other than Docker (Make is even optional, it just sets the default arguments up).
Also provides an end to end example of compiling the SDK, installing it and then using it with another C++ project.
Co-authored-by: @dsazonoff