Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup - no longer need to list Pods for GameServers #747

Merged

Conversation

markmandel
Copy link
Member

Since we changes Pod names for GameServers to be the same name as the GameServer, we no longer need to list Pods when syncing's GameServers since we can look it up directly.

Since we changes Pod names for GameServers to be the same name as the
GameServer, we no longer need to list Pods when syncing's GameServers
since we can look it up directly.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/performance Anything to do with Agones being slow, or making it go faster. labels Apr 26, 2019
@markmandel
Copy link
Member Author

/cc @ilkercelikyilmaz curious is this has any performance improvements at large scale.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f827707a-32f5-4dd0-b38c-8f3fd95f4b7a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/747/head:pr_747 && git checkout pr_747
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-58dff4d

@ilkercelikyilmaz
Copy link
Contributor

/cc @ilkercelikyilmaz curious is this has any performance improvements at large scale.

Yes it was. Especially for allocation

Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: cb9223b6-fe19-43fa-a3bb-5ffaa9da81c4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 062d0a0a-7dd3-4a73-9b9a-a75ff9f26ed1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/747/head:pr_747 && git checkout pr_747
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-7eb47c6

@markmandel markmandel merged commit 9d11068 into googleforgames:master May 1, 2019
@markmandel markmandel deleted the cleanup/remove-list-pod branch May 1, 2019 22:11
@ilkercelikyilmaz
Copy link
Contributor

I am not sure if this particular change or other change, but the allocation-shutdown-create-allocation cycle under load seems to change. It takes longer for Agones to clean-up shutdown servers. See the graph below:

image

@markmandel markmandel added this to the 0.10.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Anything to do with Agones being slow, or making it go faster. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants