-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup - no longer need to list Pods for GameServers #747
Cleanup - no longer need to list Pods for GameServers #747
Conversation
Since we changes Pod names for GameServers to be the same name as the GameServer, we no longer need to list Pods when syncing's GameServers since we can look it up directly.
/cc @ilkercelikyilmaz curious is this has any performance improvements at large scale. |
Build Succeeded 👏 Build Id: f827707a-32f5-4dd0-b38c-8f3fd95f4b7a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Yes it was. Especially for allocation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build Failed 😱 Build Id: cb9223b6-fe19-43fa-a3bb-5ffaa9da81c4 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 062d0a0a-7dd3-4a73-9b9a-a75ff9f26ed1 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Since we changes Pod names for GameServers to be the same name as the GameServer, we no longer need to list Pods when syncing's GameServers since we can look it up directly.