Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Fleet Allocation. #750

Merged
merged 2 commits into from
May 1, 2019
Merged

Deprecate Fleet Allocation. #750

merged 2 commits into from
May 1, 2019

Conversation

markmandel
Copy link
Collaborator

No description provided.

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Apr 30, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 96a6b910-481a-4c72-a551-bfdb8492e720

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/750/head:pr_750 && git checkout pr_750
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-4c06f88

@pooneh-m
Copy link
Contributor

Since FleetAllocation is in alpha version, according to this, you don't need to deprecate it, but just remove it.

The API may change in incompatible ways in a later software release without notice.

@markmandel
Copy link
Collaborator Author

It's true - but I like giving people some warning, as I know people are using FleetAllocation in production right now 😄

cyriltovena
cyriltovena approved these changes May 1, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a8f076dd-e507-49fa-b76b-ca092e5553d5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/750/head:pr_750 && git checkout pr_750
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-dd49470

@markmandel markmandel merged commit 64e1a27 into googleforgames:master May 1, 2019
@markmandel markmandel deleted the deprecate/fleetallocation branch May 1, 2019 18:07
@markmandel markmandel added this to the 0.10.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @pooneh-m @cyriltovena