Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secret list and watch permissions to RBAC rules #762

Merged
merged 2 commits into from
May 9, 2019
Merged

Add secret list and watch permissions to RBAC rules #762

merged 2 commits into from
May 9, 2019

Conversation

pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented May 8, 2019

  1. Add secret list and watch permissions to RBAC rules for agones-controller service account. Proposal: Multi-Cluster Allocation Policies #597
  2. Renamed secrets to have their extensions in the name.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5849d652-02d7-4581-8654-a1ea764a1d59

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/762/head:pr_762 && git checkout pr_762
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-64abbcf

@markmandel markmandel added area/operations Installation, updating, metrics etc kind/bug These are bugs. labels May 9, 2019
@markmandel markmandel added this to the 0.10.0 milestone May 9, 2019
markmandel
markmandel approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👟 LGTM!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: cd319aa8-0d9d-4cf2-a955-b85901256835

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/762/head:pr_762 && git checkout pr_762
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-85ae751

@markmandel markmandel merged commit 708ec07 into googleforgames:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/operations Installation, updating, metrics etc kind/bug These are bugs.
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pooneh-m @agones-bot @markmandel