Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent race conditions by syncing node cache on GameServer controller #782

Merged
merged 1 commit into from
May 21, 2019

Conversation

markmandel
Copy link
Member

Added cache.InformerSynced for Nodes on startup, to avoid race conditions.

This also included fix for flakey tests for the same reason.

Added cache.InformerSynced for Nodes on startup, to avoid race
conditions.

This also included fix for flakey tests for the same reason.
@markmandel markmandel added kind/bug These are bugs. area/tests Unit tests, e2e tests, anything to make sure things don't break labels May 17, 2019
@markmandel markmandel added this to the 0.11.0 milestone May 17, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ca16976a-0990-4e26-b2be-4e47b4de7e28

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7b59e4d0-766e-4463-8035-8cc9b1be68b1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/782/head:pr_782 && git checkout pr_782
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-e029a9e

@jkowalski jkowalski merged commit a978fdd into googleforgames:master May 21, 2019
@markmandel markmandel deleted the bug/gameservers-node branch June 19, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants