Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: FleetAllocation example fix #788

Merged
merged 3 commits into from
May 24, 2019
Merged

Docs: FleetAllocation example fix #788

merged 3 commits into from
May 24, 2019

Conversation

rorygarand
Copy link
Contributor

The example in the docs assumes a fleet with two game servers, then tries to allocate 3 game servers.

This results with a cryptic "NotFound" error resulting from trying to allocate a resource that doesn't exist.

A better solution may be to replace this example with GSA instead of FA.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2735df1b-9586-40ca-a27c-00903c4c969a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

/cc @aLekSer is this right? I defer to you on this one 😄

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels May 23, 2019
@aLekSer
Copy link
Collaborator

aLekSer commented May 24, 2019

@markmandel Yes, that is correct, because examples/simple-udp/fleet.yaml has 2 replicas in it.

aLekSer
aLekSer approved these changes May 24, 2019
View reviewed changes
Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also noticed that behaviour was 3 iterations for 2 replicas in a fleet.

markmandel
markmandel approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚵‍♂️

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7b90a628-e51d-4aaa-8ac8-c9e5f92ac896

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/788/head:pr_788 && git checkout pr_788
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-2571d09

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a2ecb8de-d24a-4e9e-946e-d736a476c463

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/788/head:pr_788 && git checkout pr_788
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-66fc72b

@markmandel markmandel merged commit ce202be into googleforgames:master May 24, 2019
@rorygarand rorygarand deleted the patch-1 branch May 25, 2019 00:12
@markmandel markmandel added this to the 0.11.0 milestone Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aLekSer aLekSer aLekSer approved these changes

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rorygarand @agones-bot @markmandel @aLekSer