Add missing validation for GameServerSet, refactor

[aLekSer]

Add common file which contains all common validations for GS, GSSet and
Fleet. Add const for some err messages.
GSSet now checks Name on Update and GS Spec on Create.

[agones-bot]

Build Failed 😱

Build Id: 25c05457-3086-4047-bb46-2e494173e5ed

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: 23783433-6002-4efb-96f3-acc014a06263

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[aLekSer]

Something went wrong with make test-gen-api-docs. Got an issue that new interface was added to the docs of API:

< <h3 id="CRDName">CRDName
< </h3>
< <p>
< <p>CRDName is an interface to get Name and Kind of CRD</p>
< </p>

[agones-bot]

Build Failed 😱

Build Id: 15cfadd2-614c-423f-b755-0a6bf57c6a12

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: 6c93c76f-1cb8-4b53-bf4f-5a7fdb97c27a

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.11.0-85fb14c
• image: gcr.io/agones-images/agones-sdk:0.11.0-85fb14c
• image: gcr.io/agones-images/agones-ping:0.11.0-85fb14c
• Linux C++ SDK (build): agonessdk-0.11.0-85fb14c-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.11.0-85fb14c.zip

A preview of the website (the last 30 builds are retained):

• https://85fb14c-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/791/head:pr_791 && git checkout pr_791
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-85fb14c

[markmandel]

Mega minor potential name change. But if you don't like it - then just merge 👍

Nice refactor!

[markmandel]

Suggested change

	type crdName interface {
	type crd interface {

Maybe? 🤷‍♂️

[aLekSer]

Good naming for this small file, applied proposed changes

[agones-bot]

Build Succeeded 👏

Build Id: d48e57ff-3d32-4138-a1dd-a1f066de1231

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.11.0-b260d97
• image: gcr.io/agones-images/agones-sdk:0.11.0-b260d97
• image: gcr.io/agones-images/agones-ping:0.11.0-b260d97
• Linux C++ SDK (build): agonessdk-0.11.0-b260d97-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.11.0-b260d97.zip

A preview of the website (the last 30 builds are retained):

• https://b260d97-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/791/head:pr_791 && git checkout pr_791
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-b260d97