Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix locust tests #797

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Fix locust tests #797

merged 1 commit into from
Jun 4, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented May 29, 2019

New allocation endpoint is used now. Pass validation of the fleet.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8cb741bc-4aa0-4e6f-a4f2-869a600fabfe

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/797/head:pr_797 && git checkout pr_797
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-d02e3de

@aLekSer
Copy link
Collaborator Author

aLekSer commented May 30, 2019

@pm7h Hello Parya,
Can you please review these changes?

@markmandel
Copy link
Member

Looks fine to me - giving @pm7h a gentle ping to make sure they are happy too! 👍

@pm7h
Copy link
Contributor

pm7h commented Jun 4, 2019

LGTM. Thanks for the fixes.

@aLekSer
Fix locust tests
ac213eb 
New allocation endpoint now used. Pass validation of the fleet.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9dfc6018-ba35-48f7-b7c9-4e010929817b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/797/head:pr_797 && git checkout pr_797
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-ac213eb

ilkercelikyilmaz
ilkercelikyilmaz approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@ilkercelikyilmaz ilkercelikyilmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel markmandel merged commit f12c566 into googleforgames:master Jun 4, 2019
@markmandel markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc labels Jun 4, 2019
@markmandel markmandel added this to the 0.11.0 milestone Jun 4, 2019
@aLekSer aLekSer deleted the fixing_locust_tests branch June 5, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pm7h pm7h pm7h approved these changes

@ilkercelikyilmaz ilkercelikyilmaz ilkercelikyilmaz approved these changes

Assignees
No one assigned
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aLekSer @agones-bot @markmandel @pm7h @ilkercelikyilmaz