Remove env namespace dependency from allocator service. #814

pooneh-m · 2019-06-06T16:58:53Z

issue #809

agones-bot · 2019-06-06T17:16:00Z

Build Failed 😱

Build Id: 7fd6c7b0-a29b-41c7-8b31-e2c05b81cea3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

cmd/allocator/main.go

agones-bot · 2019-06-06T18:03:04Z

Build Succeeded 👏

Build Id: 1882d22b-5176-4677-95cb-77d3c8995dfa

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.11.0-7072852
image: gcr.io/agones-images/agones-sdk:0.11.0-7072852
image: gcr.io/agones-images/agones-ping:0.11.0-7072852
Linux C++ SDK (build): agonessdk-0.11.0-7072852-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.11.0-7072852.zip

A preview of the website (the last 30 builds are retained):

https://7072852-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/814/head:pr_814 && git checkout pr_814
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-7072852

cmd/allocator/main.go

agones-bot · 2019-06-06T23:34:33Z

Build Succeeded 👏

Build Id: a6d052cc-0b41-4d13-bf61-6cf1c7b25ce2

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.11.0-0e67722
image: gcr.io/agones-images/agones-sdk:0.11.0-0e67722
image: gcr.io/agones-images/agones-ping:0.11.0-0e67722
Linux C++ SDK (build): agonessdk-0.11.0-0e67722-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.11.0-0e67722.zip

A preview of the website (the last 30 builds are retained):

https://0e67722-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/814/head:pr_814 && git checkout pr_814
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-0e67722

markmandel · 2019-06-06T23:46:20Z

test/e2e/allocator_test.go

@@ -80,7 +83,9 @@ func TestAllocator(t *testing.T) {
 		response, err = client.Post(requestURL, "application/json", bytes.NewBuffer(body))

 		if err != nil {
-			response.Body.Close() // nolint: errcheck
+			if response != nil {
+				response.Body.Close() // nolint: errcheck


Ah! Small Go gotcha. response.Body.Close() should always get run if the response not nil. Usually defer is a nice way to do it.

Details, and examples: https://stackoverflow.com/questions/33238518/what-could-happen-if-i-dont-close-response-body-in-golang

response.Body.Close() is happening after the poll. So this one was not necessary.

agones-bot · 2019-06-07T01:01:58Z

Build Failed 😱

Build Id: 9f43c177-0f81-4dff-8b85-9fb320896ee6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-06-07T01:06:54Z

Build Succeeded 👏

Build Id: c63f1750-3b8b-4b8b-92c6-58532e467466

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.11.0-e4f1c33
image: gcr.io/agones-images/agones-sdk:0.11.0-e4f1c33
image: gcr.io/agones-images/agones-ping:0.11.0-e4f1c33
Linux C++ SDK (build): agonessdk-0.11.0-e4f1c33-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.11.0-e4f1c33.zip

A preview of the website (the last 30 builds are retained):

https://e4f1c33-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/814/head:pr_814 && git checkout pr_814
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-e4f1c33

markmandel

🔥 awesome.

agones-bot · 2019-06-07T01:29:02Z

Build Failed 😱

Build Id: c5cc0c4d-ebdf-406c-a0c1-d74fa0b830f0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-06-07T02:11:40Z

Build Failed 😱

Build Id: eae0f125-3e73-4168-8e16-d148e2cfe4e3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-06-07T03:01:38Z

Build Failed 😱

Build Id: 28372f6b-c81b-4206-a607-75bfadd850ca

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2019-06-07T03:04:16Z

So this is consistently failing on this flaky test:

--- FAIL: TestAutoscalerWebhook (88.75s)
    fleetautoscaler_test.go:326: 
        	Error Trace:	fleetautoscaler_test.go:326
        	Error:      	Expected nil, but got: &errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ListMeta:v1.ListMeta{SelfLink:"", ResourceVersion:"", Continue:""}, Status:"Failure", Message:"Operation cannot be fulfilled on fleetautoscalers.stable.agones.dev \"simple-fleet-vc2z8-autoscaler\": the object has been modified; please apply your changes to the latest version and try again", Reason:"Conflict", Details:(*v1.StatusDetails)(0xc000992600), Code:409}}
        	Test:       	TestAutoscalerWebhook

I'll rerun this once #812 has been merged. That should solve this problem and let this pass.

agones-bot · 2019-06-07T20:13:07Z

Build Succeeded 👏

Build Id: 097ac65f-379c-4b7d-ac6f-0ad47ea7e336

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.11.0-9b9837f
image: gcr.io/agones-images/agones-sdk:0.11.0-9b9837f
image: gcr.io/agones-images/agones-ping:0.11.0-9b9837f
Linux C++ SDK (build): agonessdk-0.11.0-9b9837f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.11.0-9b9837f.zip

A preview of the website (the last 30 builds are retained):

https://9b9837f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/814/head:pr_814 && git checkout pr_814
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-9b9837f

markmandel reviewed Jun 6, 2019

View reviewed changes

cmd/allocator/main.go Outdated Show resolved Hide resolved

pooneh-m force-pushed the allocation branch 2 times, most recently from 7189d26 to 7072852 Compare June 6, 2019 17:42

googleforgames deleted a comment from agones-bot Jun 6, 2019

markmandel reviewed Jun 6, 2019

View reviewed changes

cmd/allocator/main.go Outdated Show resolved Hide resolved

pooneh-m force-pushed the allocation branch from 7072852 to 0e67722 Compare June 6, 2019 23:17

markmandel reviewed Jun 6, 2019

View reviewed changes

pooneh-m force-pushed the allocation branch 2 times, most recently from f1be9f6 to c59120a Compare June 7, 2019 00:44

Remove env namespace dependency from allocator service.

e4f1c33

pooneh-m force-pushed the allocation branch from c59120a to e4f1c33 Compare June 7, 2019 00:47

googleforgames deleted a comment from agones-bot Jun 7, 2019

markmandel approved these changes Jun 7, 2019

View reviewed changes

Merge branch 'master' into allocation

56382ab

markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc labels Jun 7, 2019

markmandel mentioned this pull request Jun 7, 2019

Batched Packed and Distributed Allocations #804

Merged

Merge branch 'master' into allocation

9b9837f

markmandel merged commit bcb0c85 into googleforgames:master Jun 7, 2019

markmandel added this to the 0.11.0 milestone Jun 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove env namespace dependency from allocator service. #814

Remove env namespace dependency from allocator service. #814

pooneh-m commented Jun 6, 2019

agones-bot commented Jun 6, 2019

agones-bot commented Jun 6, 2019

agones-bot commented Jun 6, 2019

markmandel Jun 6, 2019

pooneh-m Jun 7, 2019

markmandel Jun 7, 2019

agones-bot commented Jun 7, 2019

agones-bot commented Jun 7, 2019

markmandel left a comment

agones-bot commented Jun 7, 2019

agones-bot commented Jun 7, 2019

agones-bot commented Jun 7, 2019

markmandel commented Jun 7, 2019

agones-bot commented Jun 7, 2019

Remove env namespace dependency from allocator service. #814

Remove env namespace dependency from allocator service. #814

Conversation

pooneh-m commented Jun 6, 2019

agones-bot commented Jun 6, 2019

agones-bot commented Jun 6, 2019

agones-bot commented Jun 6, 2019

markmandel Jun 6, 2019

Choose a reason for hiding this comment

pooneh-m Jun 7, 2019

Choose a reason for hiding this comment

markmandel Jun 7, 2019

Choose a reason for hiding this comment

agones-bot commented Jun 7, 2019

agones-bot commented Jun 7, 2019

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Jun 7, 2019

agones-bot commented Jun 7, 2019

agones-bot commented Jun 7, 2019

markmandel commented Jun 7, 2019

agones-bot commented Jun 7, 2019