-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle delete events when caching Ready GameServers for Allocation #815
Handle delete events when caching Ready GameServers for Allocation #815
Conversation
Build Failed 😱 Build Id: 2c43c512-c3fe-4d70-97c9-8b5016153bb1 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
return | ||
} | ||
if newGs.IsBeingDeleted() { | ||
// TOXO: test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments are probably redundant.
Why TOXO, not TODO? Is it an abbreviation or just to distinguish from TODO?
Build Succeeded 👏 Build Id: 4bcda7ed-d9ae-4813-bbdb-fe1cae7335c4 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Whoops! That's my personal "TODO" list for while I'm working, that is easy to filter on. I forgot to remove them 🤦♂️ |
0be6b15
to
fcfba6d
Compare
Build Succeeded 👏 Build Id: 60d2426f-ebbc-48c4-a553-f4266b668bdb The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build Succeeded 👏 Build Id: d40e70aa-0ff1-4e43-8109-0fab431d539d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
No description provided.