Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PortPolicy of Passthrough - Same Port for Container and Host #817

Merged
merged 2 commits into from
Jun 12, 2019
Merged

PortPolicy of Passthrough - Same Port for Container and Host #817

merged 2 commits into from
Jun 12, 2019

Conversation

markmandel
Copy link
Member

This implements a new PortPolicy, such that the containerPort that is specified for the game server is dynamically set to the same random value that the hostPort is.

This is useful for game servers that have already been configured to broadcast the port that they originally started on as their connection port, with no overrides.

Closes #294

@markmandel
PortPolicy of Passthrough - Same Port for Container and Host
1cf5c69 
This implements a new PortPolicy, such that the containerPort that is
specified for the game server is dynamically set to the same random
value that the hostPort is.

This is useful for game servers that have already been configured to
broadcast the port that they originally started on as their connection
port, with no overrides.

Closes googleforgames#294
@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Jun 8, 2019
@markmandel
Copy link
Member Author

Question for all - are we happy with the name of the Port Policy being Passthrough ? Was the best thing I could come up with, but I'm not wedded to it. If you have a better name, please say so.

/cc @victor-prodan just to show you that I finally did this 😄

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6e7775f1-8a47-4e7a-a1e1-5005c681791a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/817/head:pr_817 && git checkout pr_817
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-1cf5c69

ilkercelikyilmaz
ilkercelikyilmaz approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@ilkercelikyilmaz ilkercelikyilmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel markmandel added this to the 0.11.0 milestone Jun 12, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 6f761edc-8b29-48f1-8faf-958b6d417937

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 97f4b675-a2bc-4d8c-b577-9de4c8475c86

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 01bd5d2c-c46b-4e30-933a-144756db4732

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/817/head:pr_817 && git checkout pr_817
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-527cae4

@markmandel markmandel merged commit e750bfe into googleforgames:master Jun 12, 2019
@markmandel markmandel deleted the feature/passthrough branch June 12, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilkercelikyilmaz ilkercelikyilmaz ilkercelikyilmaz approved these changes

Assignees
No one assigned
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones
Projects
None yet
Milestone
0.11.0
3 participants
@markmandel @agones-bot @ilkercelikyilmaz