Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reserve proto definition and generated code #820

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Reserve proto definition and generated code #820

merged 2 commits into from
Jul 2, 2019

Conversation

markmandel
Copy link
Member

The proto file definition for the reserve status in #660, and the generated clients from there.

@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Jun 11, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 1054af07-4771-4455-baa8-78abcf7fd486

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e3f028d0-1995-4338-938e-e673b5ed0a04

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/820/head:pr_820 && git checkout pr_820
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-c89834c

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a38809af-ce94-4348-972b-29cf10216942

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/820/head:pr_820 && git checkout pr_820
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-d767d7e

@markmandel markmandel added this to the 0.12.0 milestone Jun 18, 2019
@markmandel markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Jun 18, 2019
@markmandel
Reserve proto definition and generated code
dbba639 
The proto file definition for the reserve status in googleforgames#660,
and the generated clients from there.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a2ac8270-84b2-404d-8563-f6d791fcae94

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/820/head:pr_820 && git checkout pr_820
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-dbba639

@markmandel markmandel removed feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels Jun 25, 2019
ilkercelikyilmaz
ilkercelikyilmaz approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@ilkercelikyilmaz ilkercelikyilmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0c336ee3-3317-4b72-83ad-f6db08c524e3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/820/head:pr_820 && git checkout pr_820
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-90cfeec

@markmandel markmandel merged commit c94ff02 into googleforgames:master Jul 2, 2019
@markmandel markmandel deleted the feature/reserve-proto branch July 2, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilkercelikyilmaz ilkercelikyilmaz ilkercelikyilmaz approved these changes

Assignees
No one assigned
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @ilkercelikyilmaz