Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix instructions for getting pprof information from controller #822

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Fix instructions for getting pprof information from controller #822

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f4e292
Fix instructions for getting pprof information from controller
markmandel Jun 11, 2019
40d6b00
Merge branch 'master' into cleanup/pprof
markmandel Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,7 +753,7 @@ Run `make uninstall` then run `make install` again.
Run `make build-images GO_BUILD_TAGS=profile` and this will build images with [pprof](https://golang.org/pkg/net/http/pprof/)
enabled in the controller, which you can then push and install on your cluster.

To get the pprof ui working, run `make controller-portforward` (or `minikube-controller-portforward` if you are on minikube),
To get the pprof ui working, run `make controller-portforward PORT=6060` (or `minikube-controller-portforward PORT=6060` if you are on minikube),
which will setup the port forwarding to the pprof http endpoint.

Run `make pprof-web`, which will start the web interface. It may take a few minutes to start up, but it can be opened on
Expand Down