Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if NodeExternalIP is empty to fallback to NodeInternalIP #828

Merged
merged 2 commits into from
Jun 12, 2019

Conversation

aarnaud
Copy link
Contributor

@aarnaud aarnaud commented Jun 12, 2019

Check if NodeExternalIP is empty to use NodeInternalIP with private GKE cluster

Signed-off-by: Anthony ARNAUD <github@anthony-arnaud.fr>
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b9fbb768-5fc7-42ba-9c92-afadb3489e6d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9b2dd483-3a41-4e5e-9934-f043ad092d8f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/828/head:pr_828 && git checkout pr_828
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-f65939e

@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Jun 12, 2019
@markmandel markmandel added this to the 0.11.0 milestone Jun 12, 2019
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 😻

@markmandel markmandel merged commit 9f83eac into googleforgames:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants