-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check if NodeExternalIP is empty to fallback to NodeInternalIP #828
fix: check if NodeExternalIP is empty to fallback to NodeInternalIP #828
Conversation
Signed-off-by: Anthony ARNAUD <github@anthony-arnaud.fr>
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Build Failed 😱 Build Id: b9fbb768-5fc7-42ba-9c92-afadb3489e6d To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Build Succeeded 👏 Build Id: 9b2dd483-3a41-4e5e-9934-f043ad092d8f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 😻
Check if NodeExternalIP is empty to use NodeInternalIP with private GKE cluster