Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky: TestSDKSetAnnotation #837

Merged
merged 2 commits into from
Jun 18, 2019
Merged

Flaky: TestSDKSetAnnotation #837

merged 2 commits into from
Jun 18, 2019

Conversation

markmandel
Copy link
Member

Moved the application of the version annotation to ApplyDefaults() on the GameServer.

I'm not quite sure why it was this way in the first place, but this should ensure this test doesn't fail again.

@markmandel
Flaky: TestSDKSetAnnotation
90a328d 
Moved the application of the version annotation to ApplDefaults()
on the GameServer.

I'm not quite sure why it was this way in the first place, but
this should ensure this test doesn't fail again.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Jun 18, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 19177a1a-493c-401a-a2bd-d66119e1c9c3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/837/head:pr_837 && git checkout pr_837
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-90a328d

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c41d4f09-b081-4530-b031-3ff4bd0da98b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/837/head:pr_837 && git checkout pr_837
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-9961bab

@markmandel markmandel merged commit 672a1f3 into googleforgames:master Jun 18, 2019
@markmandel markmandel deleted the flaky/TestSDKSetAnnotation branch June 18, 2019 15:06
@markmandel markmandel added this to the 0.11.0 milestone Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooneh-m pooneh-m pooneh-m approved these changes

Assignees
No one assigned
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @pooneh-m