Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky: TestAllocator #839

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Flaky: TestAllocator #839

merged 1 commit into from
Jun 18, 2019

Conversation

markmandel
Copy link
Member

Move creatRestClient into the polling code, as its possible the e2e test could use the old secret, if called early enough in the flow.

@markmandel
Flaky: TestAllocator
3ae08aa 
Move creatRestClient into the polling code, as its possible the
e2e test could use the old secret, if called early enough in the flow.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Jun 18, 2019
@markmandel markmandel requested a review from pooneh-m June 18, 2019 18:01
pooneh-m
pooneh-m approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@pooneh-m pooneh-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! Let's see if it fixes the flake.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 505ae624-fd30-45b6-bfb9-60eab97813b0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/839/head:pr_839 && git checkout pr_839
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-3ae08aa

@markmandel
Copy link
Member Author

Well it passed, so hopefully this sticks!

@markmandel markmandel merged commit 8ee5791 into googleforgames:master Jun 18, 2019
@markmandel markmandel deleted the flaky/TestAllocator branch June 18, 2019 18:24
@markmandel markmandel added this to the 0.11.0 milestone Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooneh-m pooneh-m pooneh-m approved these changes

Assignees
No one assigned
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @pooneh-m