Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky: TestAutoscalerWebhook #844

Merged
merged 2 commits into from
Jun 20, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Jun 19, 2019

Waiting for exact message in PollImmediate loop.

Fixing next error which I couldn't reproduce after running 200 times the test:

--- FAIL: TestAutoscalerWebhook (72.15s)
    fleetautoscaler_test.go:351: 
            Error Trace:    fleetautoscaler_test.go:351
            Error:          "Error on scaling fleet  from 1 to 0. Error: Operation cannot be fulfilled on fleets.stable.agones.dev "simple-fleet-sspm6": the object has been modified; please apply your changes to the latest version and try again" does not contain "Error calculating desired fleet size on FleetAutoscaler"
            Test:           TestAutoscalerWebhook
            Messages:       Received unexpected error

Waiting for exact message in PollImmediate loop.
@aLekSer aLekSer force-pushed the flaky/TestAutoscalerWebhook branch from 1fd16a3 to 6439b1e Compare June 19, 2019 12:39
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f7273762-2f87-4980-96ce-5ec5bf5d6984

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 403fc24a-8105-4f31-a780-b8f48c323882

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/844/head:pr_844 && git checkout pr_844
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-6439b1e

@aLekSer
Copy link
Collaborator Author

aLekSer commented Jun 19, 2019

New one already fixed on the current master:

--- FAIL: TestFleetRecreateGameServers (263.33s)
Step #17: --- FAIL: TestFleetRecreateGameServers/pod_deletion (150.22s)

@markmandel markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc labels Jun 19, 2019
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: bf17a7f7-de78-4a69-98af-133d2d4d049d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5a58916e-aaa3-4e6f-8b56-045a13990f63

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/844/head:pr_844 && git checkout pr_844
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-ee6aff7

@markmandel markmandel merged commit f9ef4f2 into googleforgames:master Jun 20, 2019
@markmandel markmandel added this to the 0.11.0 milestone Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants