Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpp clangformat #853

Closed
wants to merge 18 commits into from
Closed

Cpp clangformat #853

wants to merge 18 commits into from

Conversation

dsazonoff
Copy link
Contributor

@dsazonoff dsazonoff commented Jun 26, 2019

Support for clang-format code formatting and code style verification. Issue: #713
Note that this PR is based on #803
Added 2 new cmake targets:

  • clang-format-apply - calls clang-format before building sources (only for non-generated files)
  • clang-format-verify - verify that current branch:commit follows google code style (a build step to verify code style of pull requests)

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c7bb3a0d-a521-4d60-be3a-280b322b93a3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 96f7f9b1-1eaf-4a1a-8336-2dc3dae67f26

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6cf316f5-750e-461d-93e6-79e755ff974d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/853/head:pr_853 && git checkout pr_853
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-6da4b1d

@dsazonoff dsazonoff marked this pull request as ready for review June 26, 2019 16:11
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a1516f0f-fe23-4cb6-898a-2cd4393c67ee

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/853/head:pr_853 && git checkout pr_853
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-f910114

@dsazonoff
Copy link
Contributor Author

Not ready yet...

@dsazonoff dsazonoff closed this Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants