Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly disable creation of the client certificate on GKE #888

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Explicitly disable creation of the client certificate on GKE #888

merged 1 commit into from
Jul 10, 2019

Conversation

roberthbailey
Copy link
Member

This is the default behavior starting with 1.12, which we are switching over to soon. Also remove the output variables for client key and client certificate as they aren't used.

Part of #717.

/assign @aLekSer

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 35c7161e-50ca-4979-be7d-1f02bc5b7e4b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/888/head:pr_888 && git checkout pr_888
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-d704922

@aLekSer
Copy link
Collaborator

aLekSer commented Jul 10, 2019

Let me check the resulted terraform configuration files.

@aLekSer
Copy link
Collaborator

aLekSer commented Jul 10, 2019 •
edited
Loading

Found one issue with small timeout in ./build/helm.tf on
resource "helm_release" "agones" should be extended to 300 seconds (3 minutes now is not enough):

  timeout = 300

Fixed here: #890

@roberthbailey
Explicitly disable creation of the client certificate on GKE, which i…
762d71c 
…s the

default starting with 1.12. Also remove the output variables for client key
and client certificate.
@markmandel markmandel added area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc labels Jul 10, 2019
markmandel
markmandel approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚒

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0f55ffb4-0e02-457d-95ba-7bd7094cd70b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/888/head:pr_888 && git checkout pr_888
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-762d71c

@markmandel markmandel added this to the 0.12.0 milestone Jul 10, 2019
@markmandel markmandel merged commit a8295b9 into googleforgames:master Jul 10, 2019
@roberthbailey roberthbailey mentioned this pull request Jul 16, 2019
Closed
5 tasks
@roberthbailey roberthbailey deleted the remove-gke-client-certs branch August 1, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@roberthbailey @agones-bot @aLekSer @markmandel