Changed cmake required version to 3.5 to work on more machines

[devjgm]

The current cmake files don't actually require 3.13, so lowering the version they claim to require will allow the cmake files to work on more machines. Related to #718

[agones-bot]

Build Failed 😱

Build Id: 90c740ae-97a1-48e1-ba60-82eb2297456b

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[dsazonoff]

I don't think that cmake version should be downgraded. It is very easy to upgrade it. And SDK supports docker build, so it doesn't matter for a machine what version to have.
There was a request from @markmandel to silent CMake output and there was a bug in older versions of CMake when output was not silenced for some platforms. If necessary, I can find an issue in cmake bugtracker. But it is not critical.

Don't forget to patch 'cpp/cmake/clang-verify.in' file and Dockerfile that are responsible for SDK builds (installation of CMake).

[devjgm]

I don't think that cmake version should be downgraded. It is very easy to upgrade it.

My distro is using a debian mirror that's slightly behind, and the newest cmake I can get is 3.12.1. So my only choice is to either: (A) download cmake from kitware.com (yuck), or (B) edit the "cmake_minimum_required" version to something slightly lower, which works fine.

FTR, we choose to require cmake 3.5 for https://github.com/googleapis/google-cloud-cpp because it's easily available on a large variety of important Linux distros, and it actually has most of the major modern features that people want/need with cmake.

And SDK supports docker build, so it doesn't matter for a machine what version to have.

Are there instructions for that? Because running make, as I did, used my locally installed cmake and did not use docker.

Don't forget to patch 'cpp/cmake/clang-verify.in' file and Dockerfile that are responsible for SDK builds (installation of CMake).

I'm sorry, but I don't see any mention of clang-verify.in. Can you please provide a few more details or point me at the documentation? Thanks.

[dsazonoff]

Now I agree about downgrading cmake version.

Are there instructions for that? Because running make, as I did, used my locally installed cmake and did not use docker.

You may look here. Or here. But I usually build everything locally, without docker.
I was talking about this Dockerfile. I was wrong in my previous comment. I think we should downgrade cmake version in CMakeLists.txt files, but keep use v3.14 in docker build. So minimal supported version will be 3.5, but cloud build will use 3.14.

I'm sorry, but I don't see any mention of clang-verify.in

I noticed that you created your PR before #855 was merged.

Please, update from master and fix cmake version in clang-verify too.
Other things are fine.

[devjgm]

Updated. Requiring 3.5 but using 3.14 in Docker sounds like a good idea to me.

[agones-bot]

Build Succeeded 👏

Build Id: 8f53308f-26f6-44db-b9f3-3438b9cdc88d

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.12.0-c801d68
• image: gcr.io/agones-images/agones-sdk:0.12.0-c801d68
• image: gcr.io/agones-images/agones-ping:0.12.0-c801d68
• Linux C++ SDK (build): agonessdk-0.12.0-c801d68-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.12.0-c801d68.zip

A preview of the website (the last 30 builds are retained):

• https://c801d68-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/903/head:pr_903 && git checkout pr_903
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-c801d68

[agones-bot]

Build Succeeded 👏

Build Id: 23d34505-5c56-4eae-ba65-8fe1feaf5775

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.12.0-1389a24
• image: gcr.io/agones-images/agones-sdk:0.12.0-1389a24
• image: gcr.io/agones-images/agones-ping:0.12.0-1389a24
• Linux C++ SDK (build): agonessdk-0.12.0-1389a24-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.12.0-1389a24.zip

A preview of the website (the last 30 builds are retained):

• https://1389a24-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/903/head:pr_903 && git checkout pr_903
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-1389a24

[markmandel]

❇️

[agones-bot]

Build Succeeded 👏

Build Id: df813d7e-2fd3-4d2b-9e03-082346157802

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.12.0-b069fd9
• image: gcr.io/agones-images/agones-sdk:0.12.0-b069fd9
• image: gcr.io/agones-images/agones-ping:0.12.0-b069fd9
• Linux C++ SDK (build): agonessdk-0.12.0-b069fd9-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.12.0-b069fd9.zip

A preview of the website (the last 30 builds are retained):

• https://b069fd9-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/903/head:pr_903 && git checkout pr_903
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-b069fd9

[roberthbailey]

@devjgm - should we also update https://github.com/googleforgames/agones/blob/master/examples/cpp-simple/CMakeLists.txt to specify cmake 3.5?

[devjgm]

I think so, yes. I didn't know "examples/cpp-simple" existed, otherwise I'd have updated it. But I see no reason for it to be different. Thanks for pointing this out.