Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmake. Removed unused script. #907

Merged
merged 2 commits into from
Jul 16, 2019
Merged

Cmake. Removed unused script. #907

merged 2 commits into from
Jul 16, 2019

Conversation

dsazonoff
Copy link
Contributor

I forgot to remove Fetch_gRPC.cmake file in #803
It is not used anymore.
@devjgm could you do a review, please?

devjgm
devjgm approved these changes Jul 14, 2019
View reviewed changes
Copy link
Contributor

@devjgm devjgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't appear to be used anymore, so removing LGTM. I have no authority in this repo, so I'm not sure if my approval means anything :-)

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: dfbaa636-decf-48e4-8d09-af9de09b9017

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/907/head:pr_907 && git checkout pr_907
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-fc7ad8a

@roberthbailey
Copy link
Member

/lgtm

/assign @markmandel for approval and merge.

cyriltovena
cyriltovena approved these changes Jul 16, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8ad74941-06d3-42ec-a1f9-886927d771bb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 92ebd363-227c-4802-8e7f-35eb206defcf

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a2bfc15e-c769-4d1f-84e2-cd6f829da44e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 65ce3a86-c932-47c2-85dd-0c0c3a219744

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/907/head:pr_907 && git checkout pr_907
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-6f00a0f

@markmandel markmandel merged commit 3161686 into googleforgames:master Jul 16, 2019
@roberthbailey roberthbailey mentioned this pull request Jul 16, 2019
Closed
5 tasks
@roberthbailey roberthbailey added this to the 0.12.0 milestone Jul 26, 2019
@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc labels Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devjgm devjgm devjgm approved these changes

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@dsazonoff @agones-bot @roberthbailey @cyriltovena @devjgm @markmandel