Compliance tests for Reserve(seconds). #920

markmandel · 2019-07-17T23:54:51Z

Currently only running in the golang test, as that's the only one that implements SDK.Reserve(seconds).

Added a couple of cleanup items in the conformance test makefile as well.

Work on #660

markmandel · 2019-07-17T23:55:02Z

@aLekSer you happy with these changes?

agones-bot · 2019-07-18T00:30:30Z

Build Succeeded 👏

Build Id: aa66807e-c4f3-4028-ad43-dd583c9cba1e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-59a0cfd
image: gcr.io/agones-images/agones-sdk:0.12.0-59a0cfd
image: gcr.io/agones-images/agones-ping:0.12.0-59a0cfd
Linux C++ SDK (build): agonessdk-0.12.0-59a0cfd-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-59a0cfd.zip

A preview of the website (the last 30 builds are retained):

https://59a0cfd-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/920/head:pr_920 && git checkout pr_920
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-59a0cfd

test/sdk/go/sdk-client-test.go

build/includes/sdk.mk

agones-bot · 2019-07-19T00:06:28Z

Build Failed 😱

Build Id: a63f4292-8541-48c8-9d49-2784a5b6fd30

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-19T01:01:29Z

Build Succeeded 👏

Build Id: 0bfb04ac-3260-4fa3-a33f-60d196c44946

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-28d4a15
image: gcr.io/agones-images/agones-sdk:0.12.0-28d4a15
image: gcr.io/agones-images/agones-ping:0.12.0-28d4a15
Linux C++ SDK (build): agonessdk-0.12.0-28d4a15-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-28d4a15.zip

A preview of the website (the last 30 builds are retained):

https://28d4a15-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/920/head:pr_920 && git checkout pr_920
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-28d4a15

roberthbailey · 2019-07-19T05:28:36Z

test/sdk/nodejs/node_modules/agones

@@ -0,0 +1 @@
+../../../../sdks/nodejs


Should this file (and the next one) but added? They appear when I run tests but I'm not sure whether they should be checked in.

oops! probably not. Let me go back and remove them.

Should I .gitignore them now, since I'm in there?

That sounds like a good idea.

agones-bot · 2019-07-19T06:01:48Z

Build Succeeded 👏

Build Id: 7511bf54-880b-42bf-882f-86741f78b1be

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-0fbabca
image: gcr.io/agones-images/agones-sdk:0.12.0-0fbabca
image: gcr.io/agones-images/agones-ping:0.12.0-0fbabca
Linux C++ SDK (build): agonessdk-0.12.0-0fbabca-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-0fbabca.zip

A preview of the website (the last 30 builds are retained):

https://0fbabca-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/920/head:pr_920 && git checkout pr_920
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-0fbabca

Currently only running in the golang test, as that's the only one that impements it.

agones-bot · 2019-07-19T23:49:28Z

Build Succeeded 👏

Build Id: c3386e98-cf96-46f7-8312-b21baa90ad65

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-8833914
image: gcr.io/agones-images/agones-sdk:0.12.0-8833914
image: gcr.io/agones-images/agones-ping:0.12.0-8833914
Linux C++ SDK (build): agonessdk-0.12.0-8833914-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-8833914.zip

A preview of the website (the last 30 builds are retained):

https://8833914-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/920/head:pr_920 && git checkout pr_920
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-8833914

agones-bot · 2019-07-20T03:03:46Z

Build Succeeded 👏

Build Id: 822df0b6-0d1d-4fc4-81c8-19ba750fab57

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-19f6a99
image: gcr.io/agones-images/agones-sdk:0.12.0-19f6a99
image: gcr.io/agones-images/agones-ping:0.12.0-19f6a99
Linux C++ SDK (build): agonessdk-0.12.0-19f6a99-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-19f6a99.zip

A preview of the website (the last 30 builds are retained):

https://19f6a99-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/920/head:pr_920 && git checkout pr_920
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-19f6a99

aLekSer · 2019-07-22T09:41:12Z

Thanks for improving make targets.

markmandel added kind/feature New features for Agones area/tests Unit tests, e2e tests, anything to make sure things don't break labels Jul 17, 2019

roberthbailey reviewed Jul 18, 2019

View reviewed changes

test/sdk/go/sdk-client-test.go Show resolved Hide resolved

build/includes/sdk.mk Show resolved Hide resolved

markmandel force-pushed the feature/reserve-compliance branch from 59a0cfd to e63f0a6 Compare July 18, 2019 23:39

markmandel force-pushed the feature/reserve-compliance branch from e63f0a6 to 28d4a15 Compare July 19, 2019 00:29

roberthbailey reviewed Jul 19, 2019

View reviewed changes

Compliance tests for Reserve(seconds).

8833914

Currently only running in the golang test, as that's the only one that impements it.

markmandel force-pushed the feature/reserve-compliance branch from 0fbabca to 8833914 Compare July 19, 2019 23:16

roberthbailey approved these changes Jul 20, 2019

View reviewed changes

Merge branch 'master' into feature/reserve-compliance

19f6a99

roberthbailey merged commit f3e050d into googleforgames:master Jul 20, 2019

markmandel deleted the feature/reserve-compliance branch July 20, 2019 03:16

markmandel added this to the 0.12.0 milestone Jul 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compliance tests for Reserve(seconds). #920

Compliance tests for Reserve(seconds). #920

markmandel commented Jul 17, 2019 •

edited

Loading

markmandel commented Jul 17, 2019

agones-bot commented Jul 18, 2019

agones-bot commented Jul 19, 2019

agones-bot commented Jul 19, 2019

roberthbailey Jul 19, 2019

markmandel Jul 19, 2019

roberthbailey Jul 19, 2019

agones-bot commented Jul 19, 2019

agones-bot commented Jul 19, 2019

agones-bot commented Jul 20, 2019

aLekSer commented Jul 22, 2019

		@@ -0,0 +1 @@
		../../../../sdks/nodejs

Compliance tests for Reserve(seconds). #920

Compliance tests for Reserve(seconds). #920

Conversation

markmandel commented Jul 17, 2019 • edited Loading

markmandel commented Jul 17, 2019

agones-bot commented Jul 18, 2019

agones-bot commented Jul 19, 2019

agones-bot commented Jul 19, 2019

roberthbailey Jul 19, 2019

Choose a reason for hiding this comment

markmandel Jul 19, 2019

Choose a reason for hiding this comment

roberthbailey Jul 19, 2019

Choose a reason for hiding this comment

agones-bot commented Jul 19, 2019

agones-bot commented Jul 19, 2019

agones-bot commented Jul 20, 2019

aLekSer commented Jul 22, 2019

markmandel commented Jul 17, 2019 •

edited

Loading