Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With the extra whitespace the rendered output has undesirable new paragraphs. #932

Merged
merged 2 commits into from
Jul 23, 2019

Conversation

roberthbailey
Copy link
Member

Fixes a bug I introduced in #930.

Part of #703.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3e1810b3-2a2e-4c85-8aef-191e755bbbdb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/932/head:pr_932 && git checkout pr_932
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-5dedf85

@markmandel markmandel added area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Jul 22, 2019
@markmandel
Copy link
Member

Changes on the preview branch look like this:
image

I assume that wasn't quite what you were going for? 😄

@roberthbailey
Copy link
Member Author

Uh, yeah that didn't work as I'd expected. Shows what happens when I don't try it locally....

I tried a few different ways to do the whitespace and couldn't figure one out that kept the paragraphs together so the newer version is better (doesn't have the weird formatting) but isn't really what I'd like it to look like either. But it's better than what is live so I think we should commit it unless you have some tricks for fighting with the hugo markdown.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ff22fbdb-92f0-418e-b564-0d1062cd4f00

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/932/head:pr_932 && git checkout pr_932
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-83cdb9b

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 96e74f93-7a51-485e-8d02-3f10a4c0ae91

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/932/head:pr_932 && git checkout pr_932
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-b591c2f

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I don't have any special whitespace removal tricks unfortunately. I've done the best I can to get rid of them in the shortcodes, but ultimately, the ugliness usually only last <= 6 weeks (since part of release is going through and cleaning up all the feature shortcodes, so I don't think it's the end of the world

But otherwise, this LGTM!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 689b7fa5-c7ba-4fed-bbe7-058ad21f2815

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/932/head:pr_932 && git checkout pr_932
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-3e47654

@markmandel markmandel merged commit 844ebac into googleforgames:master Jul 23, 2019
@markmandel markmandel added this to the 0.12.0 milestone Jul 23, 2019
@roberthbailey roberthbailey deleted the allocator-typos branch August 1, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants