Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GameServer state diagram with Reserved #933

Merged
merged 2 commits into from
Jul 23, 2019
Merged

Update GameServer state diagram with Reserved #933

merged 2 commits into from
Jul 23, 2019

Conversation

markmandel
Copy link
Member

Update dot and generated PNG with the Reserved state, and resultant
flow from there.

Tried to keep it as simple as possible, while still representing
potential state changes.

Should be final work on #660 except for missing SDK functions.

@markmandel markmandel added kind/feature New features for Agones kind/documentation Documentation for Agones labels Jul 22, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 73ea111e-430d-41de-8eec-2d8c2c40572f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a5a36f4f-7d32-4a84-8620-cd66bb71503f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 21476bfc-8978-458c-a21f-85ec83fa8695

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/933/head:pr_933 && git checkout pr_933
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-af10868

@roberthbailey
Copy link
Member

There are a couple of places in gameserver.md where I mis-typed {% feature publishversion="0.12.0" %}} (note the lowercase 'v' in version) which is causing the currently live site to look wrong. Can you fix those while you are in that file anyway?

roberthbailey
roberthbailey reviewed Jul 22, 2019
View reviewed changes
site/static/diagrams/gameserver-states.dot Show resolved Hide resolved
site/static/diagrams/gameserver-states.dot Show resolved Hide resolved
site/static/diagrams/gameserver-states.dot Outdated
Scheduled -> RequestReady [ label="SDK.ready()", color="purple" ]
RequestReady -> Ready [ label="ready to be allocated", color="blue" ]
Reserved -> Ready [label="if seconds > 0 \nand failed to call \nSDK.allocate() " color="purple"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's difficult to tell from the diagram which arrow this note belongs to. Maybe there isn't any avoiding that though...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaked some alignment, think it looks a bit better. PTAL.

@markmandel
Update GameServer state diagram with Reserved
908acf8 
Update dot and generated PNG with the Reserved state, and resultant
flow from there.

Tried to keep it as simple as possible, while still representing
potential state changes.

Should be final work on googleforgames#660 except for missing SDK functions.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9c640105-2b5e-479b-a644-06f97c4f4207

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/933/head:pr_933 && git checkout pr_933
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-908acf8

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1149a35a-10ad-483b-9f8c-27454efa7298

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/933/head:pr_933 && git checkout pr_933
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-60b1abc

@roberthbailey roberthbailey merged commit 744dcbe into googleforgames:master Jul 23, 2019
@markmandel markmandel deleted the feature/gs-state-ref branch July 23, 2019 04:02
@roberthbailey roberthbailey added this to the 0.12.0 milestone Jul 26, 2019
@roberthbailey roberthbailey mentioned this pull request Aug 1, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

Assignees
No one assigned
Labels
kind/documentation Documentation for Agones kind/feature New features for Agones
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @roberthbailey