-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to the rust simple example. #937
Conversation
Re GKE cluster I cannot find any images under |
Build Succeeded 👏 Build Id: cbcfcd65-c425-4bd8-97b2-42c8a29a96e9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
@aLekSer - there aren't any images there (yet). I've been testing with images in my own project so that I only push images to the official project once the code has been reviewed. If you want to build your own image $ REPOSITORY=<your-repository> # e.g. gcr.io/agones-images
$ make build-image REPOSITORY=${REPOSITORY}
$ docker push ${REPOSITORY}/rust-simple-server:0.3 To run your own image, make a copy of |
@roberthbailey thanks for clarification, just want to let you note that the original gcr.io/agones-images/rust-simple-server:0.3 should be pushed at some point for others to follow |
Definitely. I just want to make sure that it works first (right now it doesn't -- see #938). |
Yes, I am new to Rust language that's why I can not provide a fix for #938 . Seems that it is needed to add some loop with sleep at the beginning on SDK connect stage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
examples/rust-simple/README.md
Outdated
``` | ||
make run | ||
kubectl create -f https://raw.githubusercontent.com/googleforgames/agones/master/examples/rust-simple/gameserver.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the C++ one, should we make this
kubectl create -f https://raw.githubusercontent.com/googleforgames/agones/master/examples/rust-simple/gameserver.yaml | |
kubectl create -f https://raw.githubusercontent.com/googleforgames/agones/<release-branch>/examples/rust-simple/gameserver.yaml |
With a note saying "Where should match the Agones version you have deployed, e.g release-0.12
"
Sound good?
Yes. Unless it looks like it won't be fixed before the 0.12.0 release in which case I'll cut out the part about running in a cluster and replace it with a warning that the rust SDK is still experimental. |
Just to confirm - this is building now, but just isn't blocking? If that;s the case, I'll approve so we at least have an example that works. |
It builds and runs following the docs. But because the container doesn't block, when running the example on GKE the pod restarts and that means that the gameserver never becomes healthy. |
Build Succeeded 👏 Build Id: 5bd8f31f-50d3-4681-8ba0-17e6e360059e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Got it - thanks! I'll take a look, see if I can work out a quick solution as well. I've used rust before in a previous life, so hopefully it will come back to me 😄 Locally. I've got some changes to the conformance tests that will also check for the blocking functionality going forward. |
And running locally works just fine. |
Build Succeeded 👏 Build Id: aaa95954-510a-4625-91e2-048be37209c9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Once #953 is merged, this should be good to go. |
I'm going to re-work this to create a new tutorial like the cpp/nodejs ones. Changes should be ready shortly. |
Build Succeeded 👏 Build Id: 503b34e3-0161-41c4-b738-79305fd96662 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 41281055-8cfb-4f75-a770-23ce3939ef97 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 754aae7f-2038-4b38-9c42-98290347c72f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
@@ -0,0 +1,203 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love these 💙
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build Succeeded 👏 Build Id: bc509ca0-bf91-4c28-a3fe-04504b36dee0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Fixes #703.
I re-ordered things into what I thought was a more useful ordering (less work -- cloud -- to more work -- local dev environment) and made it so that we could push an "official" image to the
agones-images
project so that you can run the example without needing to compile any code.One thing that is weird is that while the running locally with docker instructions work for me, when I run the sample in an actual GKE cluster the game server never moves to Ready -- even though the sidecar is getting health pings the game server never transitions out of the unhealthy state. Maybe @aLekSer has an idea of why this might be?