Add Reserve to Node.js SDK

[steven-supersolid]

Add wrapper method
Add tests
Update docs
Add missing doc entry for Allocate

Part of #927

[agones-bot]

Build Succeeded 👏

Build Id: b593ddd7-08f9-41a5-b9bc-4659985031cb

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.12.0-1d9cd98
• image: gcr.io/agones-images/agones-sdk:0.12.0-1d9cd98
• image: gcr.io/agones-images/agones-ping:0.12.0-1d9cd98
• Linux C++ SDK (build): agonessdk-0.12.0-1d9cd98-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.12.0-1d9cd98.zip

A preview of the website (the last 30 builds are retained):

• https://1d9cd98-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/955/head:pr_955 && git checkout pr_955
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-1d9cd98

[roberthbailey]

Can you also update https://github.com/googleforgames/agones/blob/master/build/includes/sdk.mk#L142 to add the conformance test for the new function?

[steven-supersolid]

I've added but noticed the conformance test does not check anything, just executes methods. I'm not really familiar with this kind of test but perhaps better if the test is written more like the existing unit tests but using the running server instead of mocking, so an integration test.

If so I can create a separate PR which will use the current unit test system to test all methods of the SDK. It might also be useful to move this to the SDK folder so it can be easily run and updated during SDK development e.g. with npm run conformance.

[agones-bot]

Build Failed 😱

Build Id: 99a5c2db-9e74-4ce4-a7b9-61ac19c989e7

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[roberthbailey]

I've added but noticed the conformance test does not check anything, just executes methods.

Interesting. I hadn't actually looked at them in detail, I just knew that the Go test was exercising different methods than the others. I guess maybe they are just validating that the methods have been implemented (e.g. that the SDK "conforms" to the proper set of functions) and we rely on individual SDK tests to make sure that the methods actually work properly?

@markmandel @aLekSer

[markmandel]

Yeah - the conformance test is to make sure the gRPC / REST calls get made -- and we get the results from the client that is expected.

We have e2e and unit results to test the actual results - but if we know the SDK clients conform to the API surface of the grpc / reset server, then we are fairly sure that the SDKs actually work.

Does that make sense?

[aLekSer]

Actually we also check that we that SDK client able to read UID and CreationTimestamp from Watch and Get GameServer endpoints and set them properly as Label and Annotation. So we have a simple feedback mechanism here.

[agones-bot]

Build Failed 😱

Build Id: 5e1f0fe1-3e0b-4155-bcec-0abe8f5f215f

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

Weird. These are go tests that are failing. Lemme retry the test.

[agones-bot]

Build Failed 😱

Build Id: 75b0369a-66fa-42f4-b052-7530a9cc3870

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

Oh man, looks like some GitHub urls got moved under you. I'll look into getting a PR in place, otherwise this will block everything

[markmandel]

This should unblock once #961 is pushed through.

[markmandel]

LGTM!

[agones-bot]

Build Succeeded 👏

Build Id: 05c98efa-058f-451f-84fa-8ed079f2455a

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.12.0-1b20116
• image: gcr.io/agones-images/agones-sdk:0.12.0-1b20116
• image: gcr.io/agones-images/agones-ping:0.12.0-1b20116
• Linux C++ SDK (build): agonessdk-0.12.0-1b20116-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-0.12.0-1b20116.zip

A preview of the website (the last 30 builds are retained):

• https://1b20116-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/955/head:pr_955 && git checkout pr_955
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-1b20116