Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs Installation use cluster size the same as dev #981

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Docs Installation use cluster size the same as dev #981

merged 1 commit into from
Aug 13, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Aug 6, 2019

Update Installation instructions, use 4 n1-standard-4 cluster as in
cluster.yml.jinja (make gcloud-test-cluster), add Metrics node pool.

roberthbailey
roberthbailey reviewed Aug 6, 2019
View reviewed changes
site/content/en/docs/Installation/_index.md Outdated
* num-nodes: The number of nodes to be created in each of the cluster's zones. Default: 3
* machine-type: The type of machine to use for nodes. Default: n1-standard-2. Depending on the needs of you game, you may wish to [have a bigger machines](https://cloud.google.com/compute/docs/machine-types).
* num-nodes: The number of nodes to be created in each of the cluster's zones. Default: 4. Depending of your needs this parameter could be changed.
* machine-type: The type of machine to use for nodes. Default: n1-standard-4. Depending on the needs of you game, you may wish to [have smaller or bigger machines](https://cloud.google.com/compute/docs/machine-types).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "needs of your game"
nit: "smaller or larger machines"

site/content/en/docs/Installation/_index.md Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d5289ddb-9e66-4025-9a6c-ac443a397ecc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer aLekSer force-pushed the docs/installation-add-metrics branch 2 times, most recently from 389a3e3 to 6e1d292 Compare August 6, 2019 08:41
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c92755d6-6e94-48d1-abb3-cb4ea3c944a6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b9abbd2f-05b4-4a83-9282-4ee935081e4e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/981/head:pr_981 && git checkout pr_981
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-6e1d292

markmandel
markmandel approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but we need to clean up the conflicts 👍

Nice touch.

@aLekSer
Copy link
Collaborator Author

aLekSer commented Aug 13, 2019

Thanks, let me resolve them.

@aLekSer aLekSer force-pushed the docs/installation-add-metrics branch from 6e1d292 to 028bca9 Compare August 13, 2019 15:51
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ee525502-4e2a-488b-a0c2-393fe8aaaf15

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ec0df3c9-4c3b-4b15-a33d-49262892f2e8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Docs Installation use cluster size the same as dev
357886c 
Update Installation instructions, use 4 n1-standard-4 cluster as in
cluster.yml.jinja (make gcloud-test-cluster), add Metrics node pool.
@aLekSer aLekSer force-pushed the docs/installation-add-metrics branch from 22edca1 to 357886c Compare August 13, 2019 16:30
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c7d0528c-9660-4407-ad07-a449960cf36a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/981/head:pr_981 && git checkout pr_981
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-357886c

@markmandel markmandel merged commit a450ca8 into googleforgames:master Aug 13, 2019
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Aug 13, 2019
@markmandel markmandel added this to the 1.0.0 milestone Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey left review comments

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@aLekSer @agones-bot @markmandel @roberthbailey