Fix instructions printed out after helm install #991

aLekSer · 2019-08-12T14:15:36Z

URLs are now pointing to agones.dev website.
Removed Markdown syntax in a txt file.

agones-bot · 2019-08-12T14:49:28Z

Build Succeeded 👏

Build Id: ee7ce22a-59ab-42f0-82f9-cbafbba407ae

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-636b53a
image: gcr.io/agones-images/agones-sdk:1.0.0-636b53a
image: gcr.io/agones-images/agones-ping:1.0.0-636b53a
Linux C++ SDK (build): agonessdk-1.0.0-636b53a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-636b53a.zip

A preview of the website (the last 30 builds are retained):

https://636b53a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/991/head:pr_991 && git checkout pr_991
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-636b53a

markmandel · 2019-08-13T17:04:28Z

install/helm/agones/templates/NOTES.txt


 Once ready you can create your first GameServer using our examples:

-'kubectl apply -f https://raw.githubusercontent.com/googleforgames/agones/master/examples/simple-udp/gameserver.yaml'
+'kubectl create -f https://raw.githubusercontent.com/googleforgames/agones/master/examples/simple-udp/gameserver.yaml'


Here's a fun question - should we be pointing people to master here. Probably not, since at some point it will be broken.

Since we're here, should we revamp this to remove all the example text, and point them to our online quickstart instead?

I figure short and sweet is likely better than all this text long term - I don't think I've ever read this, it scrolls right past when Agones installs.

WDYT?

Yes, it is definitely better to have one source of truth. So I would add a link

if we are in here, can we remove the markdown? It's a .txt file, I think it just looks weird?

yes, md is not needed in here

aLekSer · 2019-08-15T13:19:10Z

Fixed links which now point to agones.dev website.

agones-bot · 2019-08-15T13:31:12Z

Build Succeeded 👏

Build Id: 630356ee-c862-4b08-ac42-fdc69b9436ac

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-04fdf82
image: gcr.io/agones-images/agones-sdk:1.0.0-04fdf82
image: gcr.io/agones-images/agones-ping:1.0.0-04fdf82
Linux C++ SDK (build): agonessdk-1.0.0-04fdf82-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-04fdf82.zip

A preview of the website (the last 30 builds are retained):

https://04fdf82-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/991/head:pr_991 && git checkout pr_991
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-04fdf82

agones-bot · 2019-08-15T13:42:57Z

Build Failed 😱

Build Id: 7eec786a-3312-40dd-be0c-6e6642eda8fd

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2019-08-15T13:44:45Z

GS controller test failed:

Step #12 - "tests": --- FAIL: TestControllerApplyGameServerAddressAndPort (0.28s)
Step #12 - "tests": controller_test.go:916: 
Step #12 - "tests": Error Trace:	controller_test.go:916
Step #12 - "tests": Error: Expected nil, but got: error getting external address for GameServer test: error retrieving node node1 for Pod test: node "node1" not found
Step #12 - "tests": Test: TestControllerApplyGameServerAddressAndPort
Step #12 - "tests": panic: runtime error: index out of range [recovered]
...
Step #12 - "tests": /usr/local/go/src/runtime/panic.go:522 +0x1b5
Step #12 - "tests": agones.dev/agones/pkg/gameservers.TestControllerApplyGameServerAddressAndPort(0xc0002b4f00)
Step #12 - "tests": /go/src/agones.dev/agones/pkg/gameservers/controller_test.go:917 +0xf23
Step #12 - "tests": testing.tRunner(0xc0002b4f00, 0x1b37ce8)
Step #12 - "tests": /usr/local/go/src/testing/testing.go:865 +0x164
Step #12 - "tests": created by testing.(*T).Run
Step #12 - "tests": /usr/local/go/src/testing/testing.go:916 +0x69a
Step #12 - "tests": FAIL	agones.dev/agones/pkg/gameservers	2.807s

markmandel

What do you think of those suggestions?

We should check on all the components really, not just the controller.

markmandel · 2019-08-15T18:57:26Z

install/helm/agones/templates/NOTES.txt

@@ -1,29 +1,13 @@
 The Agones controller has been installed in the namespace {{ .Release.Namespace }}.


Suggested change

The Agones controller has been installed in the namespace {{ .Release.Namespace }}.

The Agones components have been installed in the namespace {{ .Release.Namespace }}.

markmandel · 2019-08-15T18:57:34Z

install/helm/agones/templates/NOTES.txt

@@ -1,29 +1,13 @@
 The Agones controller has been installed in the namespace {{ .Release.Namespace }}.

-You can watch the status by running 'kubectl --namespace {{ .Release.Namespace }} get pods -o wide -w {{ .Values.agones.serviceaccount.controller }}'
+You can get the status by running:


Suggested change

You can get the status by running:

You can get their status by running:

markmandel · 2019-08-15T18:57:42Z

install/helm/agones/templates/NOTES.txt

@@ -1,29 +1,13 @@
 The Agones controller has been installed in the namespace {{ .Release.Namespace }}.

-You can watch the status by running 'kubectl --namespace {{ .Release.Namespace }} get pods -o wide -w {{ .Values.agones.serviceaccount.controller }}'
+You can get the status by running:
+kubectl --namespace {{ .Release.Namespace }} get pods -o wide | grep {{ .Values.agones.serviceaccount.controller }}


Suggested change

kubectl --namespace {{ .Release.Namespace }} get pods -o wide | grep {{ .Values.agones.serviceaccount.controller }}

kubectl --namespace {{ .Release.Namespace }} get pods -o wide

markmandel · 2019-08-15T19:02:10Z

GS controller test failed:

Step #12 - "tests": --- FAIL: TestControllerApplyGameServerAddressAndPort (0.28s)
Step #12 - "tests": controller_test.go:916: 
Step #12 - "tests": Error Trace:	controller_test.go:916
Step #12 - "tests": Error: Expected nil, but got: error getting external address for GameServer test: error retrieving node node1 for Pod test: node "node1" not found
Step #12 - "tests": Test: TestControllerApplyGameServerAddressAndPort
Step #12 - "tests": panic: runtime error: index out of range [recovered]
...
Step #12 - "tests": /usr/local/go/src/runtime/panic.go:522 +0x1b5
Step #12 - "tests": agones.dev/agones/pkg/gameservers.TestControllerApplyGameServerAddressAndPort(0xc0002b4f00)
Step #12 - "tests": /go/src/agones.dev/agones/pkg/gameservers/controller_test.go:917 +0xf23
Step #12 - "tests": testing.tRunner(0xc0002b4f00, 0x1b37ce8)
Step #12 - "tests": /usr/local/go/src/testing/testing.go:865 +0x164
Step #12 - "tests": created by testing.(*T).Run
Step #12 - "tests": /usr/local/go/src/testing/testing.go:916 +0x69a
Step #12 - "tests": FAIL	agones.dev/agones/pkg/gameservers	2.807s

Fix in #1002

aLekSer · 2019-08-15T19:35:24Z

Cool fix of the go test.
I will apply suggestions in my fork.

URLs now pointing to agones.dev website. Removed Markdown syntax in a txt file.

aLekSer · 2019-08-15T19:45:34Z

Thanks for the comments, applied them, now text reads better.

agones-bot · 2019-08-15T19:55:00Z

Build Succeeded 👏

Build Id: c8593280-0af0-4930-a3b7-9f7a59255604

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-fd7ed3d
image: gcr.io/agones-images/agones-sdk:1.0.0-fd7ed3d
image: gcr.io/agones-images/agones-ping:1.0.0-fd7ed3d
Linux C++ SDK (build): agonessdk-1.0.0-fd7ed3d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-fd7ed3d.zip

A preview of the website (the last 30 builds are retained):

https://fd7ed3d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/991/head:pr_991 && git checkout pr_991
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-fd7ed3d

agones-bot · 2019-08-15T19:57:56Z

Build Failed 😱

Build Id: ca6f2310-6263-4f8a-a1c1-c7ee91e80ee4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2019-08-15T20:09:49Z

Leaving comments to track tests failures so we can recap when build info would be deleted.

Step #20: --- FAIL: TestFleetScaleUpEditAndScaleDown (0.01s)
Step #20: --- FAIL: TestFleetScaleUpEditAndScaleDown/Use_fleet_Patch_false (146.60s)
Step #20: fleet_test.go:120: 
Step #20: Error Trace:	fleet_test.go:120
Step #20: Error: Expected nil, but got: &errors.errorString{s:"timed out waiting for the condition"}
Step #20: Test: TestFleetScaleUpEditAndScaleDown/Use_fleet_Patch_false

agones-bot · 2019-08-15T20:18:10Z

Build Succeeded 👏

Build Id: 5419955b-6b3d-449a-9072-ad8d46639561

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.0.0-9b242e0
image: gcr.io/agones-images/agones-sdk:1.0.0-9b242e0
image: gcr.io/agones-images/agones-ping:1.0.0-9b242e0
Linux C++ SDK (build): agonessdk-1.0.0-9b242e0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.0.0-9b242e0.zip

A preview of the website (the last 30 builds are retained):

https://9b242e0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/991/head:pr_991 && git checkout pr_991
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-9b242e0

markmandel reviewed Aug 13, 2019

View reviewed changes

markmandel added area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc labels Aug 13, 2019

aLekSer force-pushed the fix/instructions-after-install branch 2 times, most recently from f477773 to 04fdf82 Compare August 15, 2019 13:17

markmandel reviewed Aug 15, 2019

View reviewed changes

aLekSer force-pushed the fix/instructions-after-install branch from 04fdf82 to fd7ed3d Compare August 15, 2019 19:41

Fix instructions printed out after helm install

9b242e0

URLs now pointing to agones.dev website. Removed Markdown syntax in a txt file.

aLekSer force-pushed the fix/instructions-after-install branch from fd7ed3d to 9b242e0 Compare August 15, 2019 19:43

markmandel approved these changes Aug 15, 2019

View reviewed changes

markmandel merged commit eca2f38 into googleforgames:master Aug 15, 2019

markmandel added this to the 1.0 milestone Aug 15, 2019

aLekSer deleted the fix/instructions-after-install branch August 16, 2019 06:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix instructions printed out after helm install #991

Fix instructions printed out after helm install #991

aLekSer commented Aug 12, 2019 •

edited

Loading

agones-bot commented Aug 12, 2019

markmandel Aug 13, 2019

aLekSer Aug 13, 2019

markmandel Aug 13, 2019

aLekSer Aug 13, 2019

aLekSer commented Aug 15, 2019 •

edited

Loading

agones-bot commented Aug 15, 2019

agones-bot commented Aug 15, 2019

aLekSer commented Aug 15, 2019 •

edited

Loading

markmandel left a comment

markmandel Aug 15, 2019

markmandel Aug 15, 2019

markmandel Aug 15, 2019

markmandel commented Aug 15, 2019

aLekSer commented Aug 15, 2019

aLekSer commented Aug 15, 2019

agones-bot commented Aug 15, 2019

agones-bot commented Aug 15, 2019

aLekSer commented Aug 15, 2019

agones-bot commented Aug 15, 2019

		@@ -1,29 +1,13 @@
		The Agones controller has been installed in the namespace {{ .Release.Namespace }}.

	The Agones controller has been installed in the namespace {{ .Release.Namespace }}.
	The Agones components have been installed in the namespace {{ .Release.Namespace }}.

	You can get the status by running:
	You can get their status by running:

	kubectl --namespace {{ .Release.Namespace }} get pods -o wide \| grep {{ .Values.agones.serviceaccount.controller }}
	kubectl --namespace {{ .Release.Namespace }} get pods -o wide

Fix instructions printed out after helm install #991

Fix instructions printed out after helm install #991

Conversation

aLekSer commented Aug 12, 2019 • edited Loading

agones-bot commented Aug 12, 2019

markmandel Aug 13, 2019

Choose a reason for hiding this comment

aLekSer Aug 13, 2019

Choose a reason for hiding this comment

markmandel Aug 13, 2019

Choose a reason for hiding this comment

aLekSer Aug 13, 2019

Choose a reason for hiding this comment

aLekSer commented Aug 15, 2019 • edited Loading

agones-bot commented Aug 15, 2019

agones-bot commented Aug 15, 2019

aLekSer commented Aug 15, 2019 • edited Loading

markmandel left a comment

Choose a reason for hiding this comment

markmandel Aug 15, 2019

Choose a reason for hiding this comment

markmandel Aug 15, 2019

Choose a reason for hiding this comment

markmandel Aug 15, 2019

Choose a reason for hiding this comment

markmandel commented Aug 15, 2019

aLekSer commented Aug 15, 2019

aLekSer commented Aug 15, 2019

agones-bot commented Aug 15, 2019

agones-bot commented Aug 15, 2019

aLekSer commented Aug 15, 2019

agones-bot commented Aug 15, 2019

aLekSer commented Aug 12, 2019 •

edited

Loading

aLekSer commented Aug 15, 2019 •

edited

Loading

aLekSer commented Aug 15, 2019 •

edited

Loading