Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename gameserver-allocator resources to agones-allocator #994

Merged
merged 3 commits into from
Aug 13, 2019
Merged

Rename gameserver-allocator resources to agones-allocator #994

merged 3 commits into from
Aug 13, 2019

Conversation

markmandel
Copy link
Member

@markmandel markmandel commented Aug 13, 2019 •
edited by roberthbailey
Loading

To keep consistency, renamed the gameserver-allocator k8s resources to being agones-allocator instead, which makes it consistent with the rest of the Agones system.

This also means that if Agones is installed in a non default namespace, it is easy to determine which resources belong to Agones.

This results in a display that looks like this:

root@f999578d0b48:/go/src/agones.dev/agones# kubectl get all --namespace=agones-system
NAME                                     READY   STATUS    RESTARTS   AGE
pod/agones-allocator-5c988b7b8d-cgtbs    1/1     Running   0          2m3s
pod/agones-allocator-5c988b7b8d-hhhr5    1/1     Running   0          2m3s
pod/agones-allocator-5c988b7b8d-pv577    1/1     Running   0          2m3s
pod/agones-controller-7db45966db-56l66   1/1     Running   0          2m
pod/agones-ping-84c64f6c9d-bdlzh         1/1     Running   0          113s
pod/agones-ping-84c64f6c9d-sjgzz         1/1     Running   0          2m3s

NAME                                TYPE           CLUSTER-IP      EXTERNAL-IP     PORT(S)            AGE
service/agones-allocator            LoadBalancer   10.51.255.102   34.83.220.20    443:32480/TCP      2m4s
service/agones-controller-service   ClusterIP      10.51.253.115   <none>          443/TCP,8080/TCP   15h
service/agones-ping-http-service    LoadBalancer   10.51.244.211   34.83.210.242   80:32317/TCP       15h
service/agones-ping-udp-service     LoadBalancer   10.51.253.63    35.233.234.9    50000:30380/UDP    15h

NAME                                DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/agones-allocator    3         3         3            3           2m4s
deployment.apps/agones-controller   1         1         1            1           15h
deployment.apps/agones-ping         2         2         2            2           15h

NAME                                           DESIRED   CURRENT   READY   AGE
replicaset.apps/agones-allocator-5c988b7b8d    3         3         3       2m4s
replicaset.apps/agones-controller-7db45966db   1         1         1       2m1s
replicaset.apps/agones-controller-96967c45f    0         0         0       15h
replicaset.apps/agones-ping-7d75f87b6c         0         0         0       15h
replicaset.apps/agones-ping-84c64f6c9d         2         2         2       2m4s

@markmandel
Rename gameserver-allocator resources to agones-allocator
882574b 
To keep consistency, renamed the gameserver-allocator k8s resources to being agones-allocator instead, which makes it
consistent with the rest of the Agones system.

This also means that if Agones is installed in a non default namespace, it is easy to determine which resources
below to agones.

This results in a display that looks like this:

```shell
root@f999578d0b48:/go/src/agones.dev/agones# kubectl get all --namespace=agones-system
NAME                                     READY   STATUS    RESTARTS   AGE
pod/agones-allocator-5c988b7b8d-cgtbs    1/1     Running   0          2m3s
pod/agones-allocator-5c988b7b8d-hhhr5    1/1     Running   0          2m3s
pod/agones-allocator-5c988b7b8d-pv577    1/1     Running   0          2m3s
pod/agones-controller-7db45966db-56l66   1/1     Running   0          2m
pod/agones-ping-84c64f6c9d-bdlzh         1/1     Running   0          113s
pod/agones-ping-84c64f6c9d-sjgzz         1/1     Running   0          2m3s

NAME                                TYPE           CLUSTER-IP      EXTERNAL-IP     PORT(S)            AGE
service/agones-allocator            LoadBalancer   10.51.255.102   34.83.220.20    443:32480/TCP      2m4s
service/agones-controller-service   ClusterIP      10.51.253.115   <none>          443/TCP,8080/TCP   15h
service/agones-ping-http-service    LoadBalancer   10.51.244.211   34.83.210.242   80:32317/TCP       15h
service/agones-ping-udp-service     LoadBalancer   10.51.253.63    35.233.234.9    50000:30380/UDP    15h

NAME                                DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/agones-allocator    3         3         3            3           2m4s
deployment.apps/agones-controller   1         1         1            1           15h
deployment.apps/agones-ping         2         2         2            2           15h

NAME                                           DESIRED   CURRENT   READY   AGE
replicaset.apps/agones-allocator-5c988b7b8d    3         3         3       2m4s
replicaset.apps/agones-controller-7db45966db   1         1         1       2m1s
replicaset.apps/agones-controller-96967c45f    0         0         0       15h
replicaset.apps/agones-ping-7d75f87b6c         0         0         0       15h
replicaset.apps/agones-ping-84c64f6c9d         2         2         2       2m4s
```
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/operations Installation, updating, metrics etc labels Aug 13, 2019
pooneh-m
pooneh-m approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@pooneh-m pooneh-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e2459773-956d-46be-a696-d07c445e44b6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/994/head:pr_994 && git checkout pr_994
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-882574b

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e2e915d7-0349-4c79-a5f6-4b50275f3df6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/994/head:pr_994 && git checkout pr_994
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-f43bb3e

@markmandel
Copy link
Member Author

@googlebot rescan

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 461ab72a-b064-47f8-adc2-bb674e10fcd7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/994/head:pr_994 && git checkout pr_994
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-b6799ca

@markmandel markmandel merged commit 9c7b3a5 into googleforgames:master Aug 13, 2019
@markmandel markmandel added this to the 1.0 milestone Aug 13, 2019
@markmandel markmandel deleted the clean/allocator-rename branch August 14, 2019 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooneh-m pooneh-m pooneh-m approved these changes

Assignees
No one assigned
Labels
area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @pooneh-m