Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding clean target for SDK conformance tests #997

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Adding clean target for SDK conformance tests #997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions build/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ Table of Contents
* [make build-sdks](#make-build-sdks)
* [make build-sdk-cpp](#make-build-sdk-cpp)
* [make run-sdk-conformance-tests](#make-run-sdk-conformance-tests)
* [make clean-sdk-conformance-tests](#make-clean-sdk-conformance-tests)
* [make test](#make-test)
* [make push](#make-push)
* [make install](#make-install)
Expand Down Expand Up @@ -430,6 +431,9 @@ Build, run and clean conformance test for a specific Agones SDK.
Run SDK conformance test.
Run SDK server (sidecar) in test mode (which would record all GRPC requests) versus all SDK test clients which should generate those requests. All methods are verified.

#### `make clean-sdk-conformance-tests`
Clean leftover binary and package files after running SDK conformance tests.

#### `make test`
Run the linter and tests

Expand Down
3 changes: 2 additions & 1 deletion build/build-sdk-images/node/clean.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.

set -ex
rm -rf /go/src/agones.dev/agones/test/sdk/nodejs/node_modules
rm /go/src/agones.dev/agones/test/sdk/nodejs/package-lock.json
rm -f /go/src/agones.dev/agones/test/sdk/nodejs/package-lock.json
2 changes: 1 addition & 1 deletion build/build-sdk-images/rust/clean.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@
set -ex
cd /go/src/agones.dev/agones/test/sdk/rust
cargo clean
rm /go/src/agones.dev/agones/test/sdk/rust/Cargo.lock
rm -f /go/src/agones.dev/agones/test/sdk/rust/Cargo.lock
rm -rf /go/src/agones.dev/agones/test/sdk/rust/target
5 changes: 5 additions & 0 deletions build/includes/sdk.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,3 +144,8 @@ run-sdk-conformance-tests:
$(MAKE) run-sdk-conformance-test SDK_FOLDER=node TESTS=ready,allocate,setlabel,setannotation,gameserver,health,shutdown,watch,reserve
$(MAKE) run-sdk-conformance-test SDK_FOLDER=go TESTS=ready,allocate,setlabel,setannotation,gameserver,health,shutdown,watch,reserve
$(MAKE) run-sdk-conformance-test SDK_FOLDER=rust

# Clean package directories and binary files left
# after building conformance tests for all SDKs supported
clean-sdk-conformance-tests:
$(MAKE) run-all-sdk-command COMMAND=clean