Fix: add Content-Type and Transfer-Encoding to matchfunction:run POST request #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeseese
requested review from
aLekSer,
HazWard,
calebatwd,
syntxerror,
sawagh,
amg84,
scosgrave and
mridulji
as code owners
mridulji
added
good first issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
The HTTP POST request to run the Match Function (
/v1/matchfunction:run) currently has noContent-Typeheader on it. This prevents parsing utils (such as https://www.npmjs.com/package/body-parser) from automatically being able to parse the JSON body. This PR adds the missingContent-Typeheader as well as theTransfer-Encodingheader.Which issue(s) this PR fixes:
There is no associated issue for this.
Special notes for your reviewer:
Here is the Slack conversation about this issue: https://open-match.slack.com/archives/CCD3H0L2D/p1673486707254609