Use thread pools #601
Merged
Use thread pools #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuse threads from pool instead of creating new thread for every task
googlebot
added
the
cla: yes
barbeau
approved these changes
Jan 22, 2020
| @@ -290,7 +293,7 @@ public void run() { | |||
| }); | |||
| renderTask.setProjection(projection); | |||
| renderTask.setMapZoom(mMap.getCameraPosition().zoom); | |||
| new Thread(renderTask).start(); | |||
| mExecutor.execute(renderTask); | |||
There was a problem hiding this comment.
Just calling out for future reference that given this Executor is instantiated via newSingleThreadExecutor() we're changing to single-threading here. But, the entire implementation appears to be effectively single-threaded anyway given the synchronized block and mViewModificationInProgress variable which will stop any other RenderTasks from being executed until this one finishes. So 👍
There was a problem hiding this comment.
That was my line of thinking exactly. There's only ever one render task in flight and potentially one queued up to run next.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse threads from pool instead of creating new thread for every task