Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Allow base URL of context to be overridden. #805

Closed
CarlRobinsonRAM opened this issue Feb 17, 2022 · 5 comments · Fixed by #806
Closed

Feature Request: Allow base URL of context to be overridden. #805

CarlRobinsonRAM opened this issue Feb 17, 2022 · 5 comments · Fixed by #806
Assignees
@amuramoto
Labels
released triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@CarlRobinsonRAM
Copy link
Contributor

Hi,

In the tests for the various APIs a class called LocalTestServerContext is used. If anybody want to make their own they are unable to due to baseUrlOverride on GeoApiContext.Builder being package private.

Please could this be changed to allow others to build a test context in a similar way!

Thanks,
Carl
@CarlRobinsonRAM CarlRobinsonRAM added triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Feb 17, 2022
@jpoehnelt
Copy link
Contributor

@CarlRobinsonRAM Thank you for opening this issue. 🙏
Please check out these other resources that might be applicable:

This is an automated message, feel free to ignore.

@CarlRobinsonRAM CarlRobinsonRAM mentioned this issue Feb 17, 2022
Merged
@CarlRobinsonRAM
Copy link
Contributor Author

@arriolac any chance you could take a look at the PR on this to determine if this is acceptable. Thanks Carl

@CarlRobinsonRAM
Copy link
Contributor Author

@jpoehnelt would you be able to review this?

@amuramoto amuramoto assigned amuramoto and unassigned arriolac Jun 1, 2022
@amuramoto
Copy link
Member

Thanks for the PR!

amuramoto added a commit to amuramoto/google-maps-services-java that referenced this issue Jun 3, 2022
@amuramoto
feat: release fix for googlemaps#805
e417406
amuramoto added a commit that referenced this issue Jun 3, 2022
@amuramoto
feat: release fix for #805 (#831)
fede06b
googlemaps-bot pushed a commit that referenced this issue Jun 3, 2022
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
916c5f5 
# [2.1.0](v2.0.1...v2.1.0) (2022-06-03)

### Features

* release fix for [#805](#805) ([#831](#831)) ([fede06b](fede06b))
@googlemaps-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amuramoto amuramoto

Labels
released triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make baseUrlOverride() public CarlRobinsonRAM/google-maps-services-java
5 participants
@arriolac @jpoehnelt @amuramoto @googlemaps-bot @CarlRobinsonRAM