Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Downgrade OkHttp 5.0.0-alpha.7 -> 4.10.0 #839

Conversation

Stephan202
Copy link
Contributor

This change partially reverts the upgrade performed in #829, and is an alternative fix for #816. OkHttp 4.10.0 depends on Kotlin 1.6.20, which is not vulnerable to CVE-2020-29582.

This downgrade also resolves #832.

See:

This change partially reverts the upgrade performed in googlemaps#829, and is an
alternative fix for googlemaps#816. OkHttp 4.10.0 depends on Kotlin 1.6.20, which
is not vulnerable to CVE-2020-29582.

This downgrade also resolves googlemaps#832.

See:
- https://square.github.io/okhttp/changelogs/changelog_4x/#version-4100
- https://nvd.nist.gov/vuln/detail/CVE-2020-29582
@Stephan202
Copy link
Contributor Author

A release with this change would help us, as our build enforces requireUpperBoundDeps. If we explicitly downgrade OkHttp to avoid an alpha release (which we don't want to use in production) then the maven-enforcer-plugin complains.

Copy link

@raghulvishnudhinesh raghulvishnudhinesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amuramoto amuramoto closed this Oct 18, 2022
@amuramoto amuramoto reopened this Oct 18, 2022
@amuramoto amuramoto merged commit 71a2128 into googlemaps:main Oct 18, 2022
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.NoClassDefFoundError: okhttp3/Interceptor
5 participants