Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: google.maps.Data object mocks #142

Merged
merged 4 commits into from
Dec 1, 2021

Conversation

eegli
Copy link
Contributor

@eegli eegli commented Nov 30, 2021

As discussed in the linked issue.
PR also includes a config update for eslint to handle EOL differences between Windows and MacOS. Otherwise, the linting will throw an error.


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #141 🦕

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 30, 2021
@eegli eegli changed the title Feature/data object mocks Add Data object mocks Nov 30, 2021
@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 30, 2021
@eegli eegli changed the title Add Data object mocks feat: google.maps.Data object mocks Nov 30, 2021
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #142 (ebaebc2) into main (d274f69) will increase coverage by 0.24%.
The diff coverage is 43.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   42.05%   42.29%   +0.24%     
==========================================
  Files          16       17       +1     
  Lines         321      383      +62     
  Branches        3        3              
==========================================
+ Hits          135      162      +27     
- Misses        186      221      +35     
Impacted Files Coverage Δ
src/data.ts 40.67% <40.67%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/map.ts 51.72% <100.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e3f5ea...ebaebc2. Read the comment docs.

@jpoehnelt jpoehnelt merged commit 805395f into googlemaps:main Dec 1, 2021
github-actions bot pushed a commit that referenced this pull request Dec 1, 2021
github-actions bot pushed a commit that referenced this pull request Dec 1, 2021
## [1.4.0](v1.3.9...v1.4.0) (2021-12-01)

### Features

*  google.maps.Data object mocks ([#142](#142)) ([805395f](805395f))

### Miscellaneous Chores

* **deps-dev:** bump jest from 27.4.0 to 27.4.2 ([#143](#143)) ([cef377f](cef377f))
* **deps-dev:** bump rollup from 2.60.1 to 2.60.2 ([#144](#144)) ([a1c606d](a1c606d))
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eegli eegli deleted the feature/data-object-mocks branch December 1, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mocks for google.maps.Data
2 participants