Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initialize Map.controls #173

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

liveFreeOrCode
Copy link
Contributor

@liveFreeOrCode liveFreeOrCode commented Jan 12, 2022

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #152 🦕


This patch implements Map.controls so users can effectively test control positioning: https://developers.google.com/maps/documentation/javascript/controls?hl=en#ControlPositioning

This patch updates the package-lock after installing
the deps using npm version 8.3.0
This patch initializes Map.controls to support the ability for
users to unit test control positioning:
https://developers.google.com/maps/documentation/javascript/controls\?hl\=en\#ControlPositioning
@liveFreeOrCode
Copy link
Contributor Author

I submitted the changes to package-lock.json from my npm i step of the contribution guidelines. Let me know if I should back out that commit as I'm unsure of your process of updating dep locks.

@jpoehnelt
Copy link
Contributor

@liveFreeOrCode
Copy link
Contributor Author

liveFreeOrCode commented Jan 12, 2022

@liveFreeOrCode Please see the CLA check details https://github.com/googlemaps/js-jest-mocks/pull/173/checks?check_run_id=4791078505

@jpoehnelt Done, you can re-run the check, assuming it's immediate - which it seems to be as I can see my CLA in my profile.

@jpoehnelt jpoehnelt merged commit e57011e into googlemaps:main Jan 12, 2022
@jpoehnelt
Copy link
Contributor

Thanks!

github-actions bot pushed a commit that referenced this pull request Jan 12, 2022
* chore: update package-lock

This patch updates the package-lock after installing
the deps using npm version 8.3.0

* feat: initialize Map.controls

This patch initializes Map.controls to support the ability for
users to unit test control positioning:
https://developers.google.com/maps/documentation/javascript/controls\?hl\=en\#ControlPositioning e57011e
github-actions bot pushed a commit that referenced this pull request Jan 12, 2022
## [2.1.0](v2.0.0...v2.1.0) (2022-01-12)

### Features

* initialize `Map.controls` ([#173](#173)) ([e57011e](e57011e))

### Miscellaneous Chores

* **deps-dev:** bump jest from 27.4.5 to 27.4.6 ([#170](#170)) ([21402c0](21402c0))
* **deps-dev:** bump jest from 27.4.6 to 27.4.7 ([#171](#171)) ([52756f2](52756f2))
* **deps-dev:** bump rollup from 2.62.0 to 2.63.0 ([#169](#169)) ([00b8de5](00b8de5))
* Synced local '.eslintrc.json' with remote 'sync-files/js/.eslintrc.json' ([#172](#172)) ([8d2ced3](8d2ced3))
@github-actions
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map.controls not mocked properly?
2 participants