feat(autocomplete): Add AutocompleteSessionToken Mocks #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessedoyle
changed the title
Previously the `google.maps.places.AutocompleteSessionToken` class was not mocked by this library. Developers implementing custom autocomplete operations would likely encounter the following error message in their tests: ``` TypeError: google.maps.places.AutocompleteSessionToken is not a constructor ``` This commit adds a mock and exports it for the `AutocompleteSessionToken` class. The constructor accepts no parameters, and the class does not expose any public functions/methods. resolves: #495
wangela
approved these changes
Aug 14, 2023
|
Thanks for fixing this, @jessedoyle! Please sync with main and we'll be able to merge this. |
|
Hey @wangela - I've merged |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
Previously the `google.maps.places.AutocompleteSessionToken` class was not mocked by this library. Developers implementing custom autocomplete operations would likely encounter the following error message in their tests: ``` TypeError: google.maps.places.AutocompleteSessionToken is not a constructor ``` This commit adds a mock and exports it for the `AutocompleteSessionToken` class. The constructor accepts no parameters, and the class does not expose any public functions/methods. resolves: #495 a59d1d8
|
🎉 This PR is included in version 2.20.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there - thanks for making a great library!
Previously the
google.maps.places.AutocompleteSessionTokenclass was not mocked by this library.Developers implementing custom autocomplete operations would likely encounter the following error message in their tests:
This PR adds a mock and exports it for the
AutocompleteSessionTokenclass. The constructor accepts no parameters, and the class does not expose any public functions/methods (docs).resolves #495
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
[] Appropriate docs were updated (if necessary)