Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only cluster and redraw markers as necessary #60

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Conversation

jpoehnelt
Copy link
Contributor

@jpoehnelt jpoehnelt commented Oct 7, 2021

This adds support for algorithms to return a changed boolean to let the main class know if all markers should be redrawn. The NoopAlgorithm and SuperClusterAlgorithm have been extended to enable this optimization.

closes #58

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #60 (3d65bc7) into main (348370c) will increase coverage by 0.96%.
The diff coverage is 79.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   70.13%   71.10%   +0.96%     
==========================================
  Files          13       13              
  Lines         298      308      +10     
  Branches       40       45       +5     
==========================================
+ Hits          209      219      +10     
- Misses         87       89       +2     
+ Partials        2        0       -2     
Impacted Files Coverage Δ
src/algorithms/core.ts 50.00% <0.00%> (ø)
src/algorithms/dbscan.ts 24.00% <ø> (ø)
src/algorithms/grid.ts 13.79% <ø> (ø)
src/algorithms/kmeans.ts 20.83% <ø> (ø)
src/algorithms/noop.ts 25.00% <33.33%> (ø)
src/algorithms/supercluster.ts 100.00% <100.00%> (ø)
src/markerclusterer.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e70c0...3d65bc7. Read the comment docs.

@jpoehnelt jpoehnelt merged commit 0d0a58b into main Oct 7, 2021
@jpoehnelt jpoehnelt deleted the fix/blink branch October 7, 2021 23:14
github-actions bot pushed a commit that referenced this pull request Oct 7, 2021
### [1.0.6](v1.0.5...v1.0.6) (2021-10-07)

### Bug Fixes

* only cluster and redraw markers as necessary ([#60](#60)) ([0d0a58b](0d0a58b))
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

🎉 This PR is included in version 1.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markers are blinking at any action
1 participant