-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(exports): export marker utils in case of creating custom algorythms #762
feat(exports): export marker utils in case of creating custom algorythms #762
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I don't see any reason why the utilities shouldn't be exported since they are pretty universally useful when dealing with mixed AdvancedMarkerElement and Marker instances.
As for the documentation, I would probably just add a note about the utils in a new section about implementing customised algorithms.
If you're up to writing something based on what you're doing, that would be much appreciated.
## [2.5.0](v2.4.1...v2.5.0) (2023-09-28) ### Features * export MarkerUtils for custom algorithm implementation ([#762](#762)) ([442a740](442a740)) ### Miscellaneous Chores * **deps-dev:** bump @babel/preset-env from 7.22.10 to 7.22.20 ([#754](#754)) ([4ac674d](4ac674d)) * **deps-dev:** bump @babel/runtime-corejs3 from 7.22.10 to 7.22.15 ([#749](#749)) ([1d1a7cd](1d1a7cd)) * **deps-dev:** bump @googlemaps/jest-mocks from 2.19.3 to 2.20.0 ([#758](#758)) ([652df12](652df12)) * **deps-dev:** bump @rollup/plugin-node-resolve from 15.2.0 to 15.2.1 ([#748](#748)) ([b4c9b17](b4c9b17)) * **deps-dev:** bump @rollup/plugin-typescript from 11.1.2 to 11.1.3 ([#739](#739)) ([8c87fa0](8c87fa0)) * **deps-dev:** bump core-js from 3.32.1 to 3.32.2 ([#753](#753)) ([95a8047](95a8047)) * **deps-dev:** bump eslint from 8.47.0 to 8.49.0 ([#746](#746)) ([e22a161](e22a161)) * **deps-dev:** bump eslint from 8.49.0 to 8.50.0 ([#759](#759)) ([b094762](b094762)) * **deps-dev:** bump selenium-webdriver from 4.11.1 to 4.12.0 ([#756](#756)) ([5ac9256](5ac9256)) * **deps-dev:** bump selenium-webdriver from 4.12.0 to 4.13.0 ([#760](#760)) ([d55373c](d55373c)) * **deps-dev:** bump typedoc from 0.25.0 to 0.25.1 ([#750](#750)) ([65396d4](65396d4))
🎉 This PR is included in version 2.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #761 🦕