Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Synced file(s) with googlemaps/.github #168

Merged
merged 3 commits into from
Oct 27, 2021
Merged

chore: Synced file(s) with googlemaps/.github #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ba424f
chore: Synced local '.github/' with remote 'sync-files/js/.github/'
googlemaps-bot Oct 27, 2021
d03fde1
chore: Synced local '.eslintrc.json' with remote 'sync-files/js/.esli…
googlemaps-bot Oct 27, 2021
99f3711
style: fix lint issues
jpoehnelt Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 15 additions & 17 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,28 @@
{
"extends": [
"eslint:recommended",
"plugin:prettier/recommended",
"plugin:@typescript-eslint/recommended"
],
"parser": "@typescript-eslint/parser",
"extends": ["eslint:recommended", "plugin:prettier/recommended"],
"parserOptions": {
"ecmaVersion": 11,
"sourceType": "module"
"ecmaVersion": 12,
"sourceType": "module",
"ecmaFeatures": {
"jsx": true
}
},
"plugins": ["@typescript-eslint", "jest"],
"plugins": ["jest"],
"rules": {
"no-var": 2,
"prefer-arrow-callback": 2,
"@typescript-eslint/ban-ts-comment": 0,
"@typescript-eslint/ban-types": 1,
"@typescript-eslint/no-empty-function": 1,
"@typescript-eslint/member-ordering": 1,
// disable the rule for all files
"@typescript-eslint/explicit-member-accessibility": "off"
"prefer-arrow-callback": 2
},
"overrides": [
{
// enable the rule specifically for TypeScript files
"files": ["*.ts", "*.tsx"],
"parser": "@typescript-eslint/parser",
"plugins": ["@typescript-eslint"],
"extends": ["plugin:@typescript-eslint/recommended"],
"rules": {
"@typescript-eslint/ban-ts-comment": 0,
"@typescript-eslint/ban-types": 1,
"@typescript-eslint/no-empty-function": 1,
"@typescript-eslint/member-ordering": 1,
"@typescript-eslint/explicit-member-accessibility": [
1,
{
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ jobs:
@semantic-release/github
@semantic-release/npm
@googlemaps/semantic-release-config
semantic-release-npm-deprecate
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_WOMBAT_TOKEN }}
14 changes: 7 additions & 7 deletions examples/google_northamerica_offices.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,11 @@
var icon = getIcon(place["icon"]);

var title = place["name"];
var posn = new google.maps.LatLng(
place["posn"][0],
place["posn"][1]
var position = new google.maps.LatLng(
place.position[0],
place.position[1]
);
var marker = createMarker(posn, title, getIcon(place["icon"]));
var marker = createMarker(position, title, getIcon(place["icon"]));
markers.push(marker);
allmarkers.push(marker);
}
Expand All @@ -104,10 +104,10 @@
updateStatus(mgr.getMarkerCount(map.getZoom()));
}

function createMarker(posn, title, icon) {
function createMarker(position, title, icon) {
var markerOptions = {
position: posn,
title: title
position,
title,
};
if (icon !== false) {
markerOptions.shadow = icon.shadow;
Expand Down
63 changes: 32 additions & 31 deletions examples/google_northamerica_offices.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable no-unused-vars */
let iconData = {
us: { width: 24, height: 14 },
ca: { width: 24, height: 14 },
Expand All @@ -15,12 +16,12 @@ let officeLayer = [
{
name: "USA Offices",
icon: ["us", "flag-shadow"],
posn: [40, -97],
position: [40, -97],
},
{
name: "Canadian Offices",
icon: ["ca", "flag-shadow"],
posn: [58, -101],
position: [58, -101],
},
],
},
Expand All @@ -30,67 +31,67 @@ let officeLayer = [
{
name: "Headquarters",
icon: ["headquarters", "headquarters-shadow"],
posn: [37.423021, -122.083739],
position: [37.423021, -122.083739],
},
{
name: "New York Sales & Engineering Office",
icon: ["house", "house-shadow"],
posn: [40.754606, -73.986794],
position: [40.754606, -73.986794],
},
{
name: "Atlanta Sales & Engineering Office",
icon: ["house", "house-shadow"],
posn: [33.781506, -84.387422],
position: [33.781506, -84.387422],
},
{
name: "Dallas Sales Office",
icon: ["house", "house-shadow"],
posn: [36.4724385, -101.044637],
position: [36.4724385, -101.044637],
},
{
name: "Cambridge Sales & Engineering Office",
icon: ["house", "house-shadow"],
posn: [42.362331, -71.083661],
position: [42.362331, -71.083661],
},
{
name: "Chicago Sales Office",
icon: ["house", "house-shadow"],
posn: [41.889232, -87.628767],
position: [41.889232, -87.628767],
},
{
name: "Denver & Boulder Offices",
icon: ["house", "house-shadow"],
posn: [39.563011, -104.868962],
position: [39.563011, -104.868962],
},
{
name: "Detroit Sales Office",
icon: ["house", "house-shadow"],
posn: [42.475482, -83.244587],
position: [42.475482, -83.244587],
},
{
name: "Santa Monica & Irvine Offices",
icon: ["house", "house-shadow"],
posn: [33.715585, -118.177435],
position: [33.715585, -118.177435],
},
{
name: "Phoenix Sales & Engineering Office",
icon: ["house", "house-shadow"],
posn: [33.411782, -111.926247],
position: [33.411782, -111.926247],
},
{
name: "Pittsburgh Engineering Office",
icon: ["house", "house-shadow"],
posn: [40.444541, -79.946254],
position: [40.444541, -79.946254],
},
{
name: "Seattle Engineering & Sales Offices",
icon: ["house", "house-shadow"],
posn: [47.664261, -122.274308],
position: [47.664261, -122.274308],
},
{
name: "Canada Sales Office",
icon: ["house", "house-shadow"],
posn: [43.645478, -79.378843],
position: [43.645478, -79.378843],
},
],
},
Expand All @@ -99,67 +100,67 @@ let officeLayer = [
places: [
{
name: "Headquarters",
posn: [37.423021, -122.083739],
position: [37.423021, -122.083739],
},
{
name: "New York Sales & Engineering Office",
posn: [40.754606, -73.986794],
position: [40.754606, -73.986794],
},
{
name: "Atlanta Sales & Engineering Office",
posn: [33.781506, -84.387422],
position: [33.781506, -84.387422],
},
{
name: "Boulder Sales & Engineering Office",
posn: [40.01852, -105.276882],
position: [40.01852, -105.276882],
},
{
name: "Cambridge Sales & Engineering Office",
posn: [42.362331, -71.083661],
position: [42.362331, -71.083661],
},
{
name: "Chicago Sales Office",
posn: [41.889232, -87.628767],
position: [41.889232, -87.628767],
},
{
name: "Dallas Sales Office",
posn: [32.925355, -96.816087],
position: [32.925355, -96.816087],
},
{
name: "Denver Sales Office",
posn: [39.563011, -104.868962],
position: [39.563011, -104.868962],
},
{
name: "Detroit Sales Office",
posn: [42.475482, -83.244587],
position: [42.475482, -83.244587],
},
{
name: "Irvine Sales & Engineering Office",
posn: [33.660021, -117.860142],
position: [33.660021, -117.860142],
},
{
name: "Phoenix Sales & Engineering Office",
posn: [33.411782, -111.926247],
position: [33.411782, -111.926247],
},
{
name: "Pittsburgh Engineering Office",
posn: [40.444541, -79.946254],
position: [40.444541, -79.946254],
},
{
name: "Santa Monica Sales & Engineering Office",
posn: [34.019388, -118.494728],
position: [34.019388, -118.494728],
},
{
name: "Seattle Engineering Office",
posn: [47.678415, -122.195713],
position: [47.678415, -122.195713],
},
{
name: "Seattle Sales Office",
posn: [47.650106, -122.352903],
position: [47.650106, -122.352903],
},
{
name: "Toronto Sales Office",
posn: [43.645478, -79.378843],
position: [43.645478, -79.378843],
},
],
},
Expand Down