-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SnappedPoint.yml #398
Conversation
Clarifying that the Nearest Roads API may send several objects for the same index. This differs from the Snap to Roads API but isn't outlined here. See nearest roads vs snap to roads: https://roads.googleapis.com/v1/nearestRoads?points=58.3441718,12.3007768&key=REDACTED https://roads.googleapis.com/v1/snapToRoads?path=58.3441718,12.3007768&key=REDACTED
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Actually, it might be a better idea to change this text to plural? The Roads API takes up to 100 independent coordinates, and returns the closest road segment for each point. The points passed do not need to be part of a continuous path. |
/update-dist |
@nora-soderlund thank you for your contribution. We have updated our workflow to update dist after the pull request is merged. I apologize for using update-dist to add changed files to your pull request which are causing merge conflicts. Would you please:
If all goes correctly, there should only be 3 changed files left in the PR; the ones under /specification. Thank you! |
@wangela I've reverted the changes to /dist now, I wasn't sure how to do it earlier, thank you! :) |
Thanks for the PR @nora-soderlund! |
🎉 This PR is included in version 1.22.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Clarifying that the Nearest Roads API may send several objects for the same index. This differs from the Snap to Roads API but isn't outlined here:
https://developers.google.com/maps/documentation/roads/nearest
See nearest roads vs snap to roads:
https://roads.googleapis.com/v1/nearestRoads?points=58.3441718,12.3007768&key=REDACTED https://roads.googleapis.com/v1/snapToRoads?path=58.3441718,12.3007768&key=REDACTED