Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SnappedPoint.yml #398

Merged
merged 5 commits into from
Dec 12, 2022
Merged

Update SnappedPoint.yml #398

merged 5 commits into from
Dec 12, 2022

Conversation

nora-soderlund
Copy link
Contributor

@nora-soderlund nora-soderlund commented Oct 26, 2022

Clarifying that the Nearest Roads API may send several objects for the same index. This differs from the Snap to Roads API but isn't outlined here:
https://developers.google.com/maps/documentation/roads/nearest

See nearest roads vs snap to roads:
https://roads.googleapis.com/v1/nearestRoads?points=58.3441718,12.3007768&key=REDACTED https://roads.googleapis.com/v1/snapToRoads?path=58.3441718,12.3007768&key=REDACTED

Clarifying that the Nearest Roads API may send several objects for the same index. This differs from the Snap to Roads API but isn't outlined here.

See nearest roads vs snap to roads:
https://roads.googleapis.com/v1/nearestRoads?points=58.3441718,12.3007768&key=REDACTED
https://roads.googleapis.com/v1/snapToRoads?path=58.3441718,12.3007768&key=REDACTED
@google-cla
Copy link

google-cla bot commented Oct 26, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@nora-soderlund
Copy link
Contributor Author

Actually, it might be a better idea to change this text to plural?

The Roads API takes up to 100 independent coordinates, and returns the closest road segment for each point. The points passed do not need to be part of a continuous path.

@amuramoto amuramoto enabled auto-merge (squash) October 26, 2022 21:01
@nora-soderlund nora-soderlund marked this pull request as draft October 27, 2022 06:07
auto-merge was automatically disabled October 27, 2022 06:07

Pull request was converted to draft

@nora-soderlund nora-soderlund marked this pull request as ready for review October 27, 2022 06:12
@amuramoto amuramoto enabled auto-merge (squash) October 27, 2022 16:59
@wangela
Copy link
Member

wangela commented Oct 27, 2022

/update-dist

@amuramoto amuramoto disabled auto-merge October 27, 2022 18:23
@wangela
Copy link
Member

wangela commented Nov 11, 2022

@nora-soderlund thank you for your contribution. We have updated our workflow to update dist after the pull request is merged. I apologize for using update-dist to add changed files to your pull request which are causing merge conflicts. Would you please:

  1. Revert the changes to /dist by git checkout origin/main -- dist
  2. Commit the reverted changes

If all goes correctly, there should only be 3 changed files left in the PR; the ones under /specification.

Thank you!

@wangela wangela closed this Nov 11, 2022
@wangela wangela reopened this Nov 11, 2022
@nora-soderlund
Copy link
Contributor Author

@wangela I've reverted the changes to /dist now, I wasn't sure how to do it earlier, thank you! :)

@nora-soderlund
Copy link
Contributor Author

@wangela

@amuramoto amuramoto merged commit 3900552 into googlemaps:main Dec 12, 2022
@amuramoto
Copy link
Member

Thanks for the PR @nora-soderlund!

@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 1.22.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants