Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace yaml with github.com/goccy/go-yaml #119

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

JanDeDobbeleer
Copy link
Contributor

The currently used YAML library isn't updated anymore, but go-yaml is. I validated this for oh-my-posh and everything seems to work.

The reason I want to do this, is so that I can push an update to the go-yaml library to fix issues with Nerd Font glyphs not being recognised resulting in a non-quoted string, which in YAML makes them literal text rather than icons. This breaks config exports and migrations for oh-my-posh.

Example:

map[string]string{"v": "\ue0b6"},

Is encoded to YAML as:

v: \ue0b6

But that should be:

v: "\ue0b6"

I understand this doesn't really matter for this project, but providing context on why this is relevant for me is always a good idea, no?

@inhere inhere added the enhancement New feature or request label Feb 10, 2023
@inhere inhere merged commit 9993ffa into gookit:master Feb 11, 2023
@inhere
Copy link
Member

inhere commented Feb 11, 2023

Thanks, will release on next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants