Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GradientTexture2D #170

Merged
merged 1 commit into from
Jan 8, 2022
Merged

Remove GradientTexture2D #170

merged 1 commit into from
Jan 8, 2022

Conversation

Xrayez
Copy link
Contributor

@Xrayez Xrayez commented Jan 7, 2022

Merged in Godot 3.x now, see godotengine/godot#54824, therefore mission accomplished. 🙂

Merged in Godot now.
@Xrayez
Copy link
Contributor Author

Xrayez commented Jan 7, 2022

Note that godotengine/godot#54824 introduces a regression in relation to Goost features, waiting until godotengine/godot#56603 is merged before removing the class in Goost.

@Xrayez Xrayez added the Waiting for Godot ⏳ The engine needs a fix or an enhancement to fix the issue label Jan 7, 2022
@Xrayez
Copy link
Contributor Author

Xrayez commented Jan 8, 2022

Lets merge the PR I guess, even if this means introducing a regression with Light2D (I no longer have maintainer privileges in Godot to fix the bug promptly, unfortunately). Besides, it's not currently possible to build Goost on latest Godot 3.x branch (duplicate symbols caused by merging the same feature in Godot).

But hopefully godotengine/godot#56603 gets eventually merged, so we won't have to patch the Godot source for this.

@Xrayez Xrayez merged commit 271c1ed into gd3 Jan 8, 2022
@Xrayez Xrayez deleted the remove-gradient-texture-2d branch January 8, 2022 18:30
@Xrayez Xrayez removed the Waiting for Godot ⏳ The engine needs a fix or an enhancement to fix the issue label Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant