-
-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error on gopass sync
: Failed to decode public key 0xC6C033490CF29EF1: failed to read key ring: openpgp: unsupported feature: public key type: 22
#2192
Comments
This should work in any case since gopass is actually calling Maybe you could consider running the command with a DEBUG log file:
and share with us the (redacted) log? Do you have the same binary for both |
Hey @AnomalRoil ,
$ ls -l /usr/bin/gpg2
lrwxrwxrwx 1 root root 3 Jun 21 2021 /usr/bin/gpg2 -> gpg
$ gpg2 --version
gpg (GnuPG) 2.2.20
libgcrypt 1.8.8
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Home: /home/jonas/.gnupg
Supported algorithms:
Pubkey: RSA, ELG, DSA, ECDH, ECDSA, EDDSA
Cipher: IDEA, 3DES, CAST5, BLOWFISH, AES, AES192, AES256, TWOFISH,
CAMELLIA128, CAMELLIA192, CAMELLIA256
Hash: SHA1, RIPEMD160, SHA256, SHA384, SHA512, SHA224
Compression: Uncompressed, ZIP, ZLIB, BZIP2 The full log is here:
Note that there are two different errors:
|
Here is where it blows up https://github.com/gopasspw/gopass/blob/v1.14.0/internal/store/leaf/crypto.go#L62 Then in gopass/internal/store/leaf/crypto.go Line 86 in fc57e3f
So
but does not support ed25519 keys. This also explains why the manual import works as a workaround. I have never written a single line of go (and not planning to) so (as I'm unable to provide a patch) I'm living with the workaround. |
@kastnerp Do you have any more input? |
Okay, I guess it's time to simply try to migrate to the maintained https://github.com/ProtonMail/go-crypto |
RELEASE_NOTES=[REFACTORING] Migrating to a maintained version of openpgp Fixes #2192
RELEASE_NOTES=[REFACTORING] Migrating to a maintained version of openpgp Fixes #2192 Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
RELEASE_NOTES=[CLEANUP] Migrating to a maintained version of openpgp Fixes #2192 Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
RELEASE_NOTES=[CLEANUP] Migrating to a maintained version of openpgp Fixes #2192 Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
Using a compiled version of the
I didn't expect this to be fixed that fast! |
Well, this one is really thanks to the work done by the amazing team at Protonmail! And also thanks to your investigative work that allowed us to quickly pinpoint the issue. I had forgotten we were relying on a native lib as well as on gpg for public key stuff. |
RELEASE_NOTES=[CLEANUP] Migrating to a maintained version of openpgp Fixes gopasspw#2192 Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
Summary
The command
gopass sync
fails to read / importcv25519
keys. A workaround is to runbefore every
gopass sync
.From what I can see is that
gopass
uses thecrypto
package of Go. This supports ed25519. Is there something I'm missing?Steps To Reproduce
Expected behavior
I expected gopass to import the GPG keys into my keyring;
Environment
Linux jonas-cc 5.13.0-40-generic #45-Ubuntu SMP Tue Mar 29 14:48:14 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
gopass 1.14.0 go1.18 linux amd64
dpkg -i ...deb
Additional context
The text was updated successfully, but these errors were encountered: